From patchwork Tue May 23 00:12:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 9741549 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0528B60388 for ; Tue, 23 May 2017 00:13:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DEE3328770 for ; Tue, 23 May 2017 00:13:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2E752877B; Tue, 23 May 2017 00:13:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE97428770 for ; Tue, 23 May 2017 00:13:38 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 773A426705B; Tue, 23 May 2017 02:13:37 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2F8DA26705D; Tue, 23 May 2017 02:13:36 +0200 (CEST) Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by alsa0.perex.cz (Postfix) with ESMTP id 1B0C0267049 for ; Tue, 23 May 2017 02:13:27 +0200 (CEST) Received: by mail-pf0-f181.google.com with SMTP id n23so96795932pfb.2 for ; Mon, 22 May 2017 17:13:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gLi1JLSeox6/VvTbaMv2ie6OkGqr8ktpvBzz+Q7mZiE=; b=IKkWzId289NxhK9kR1xgsa+9ayNYf71pGHYN0jhVpIkKMhdVDWxNckpUFXG9awJ+6M I27IqKiQL7aOnD7JSjGqynF6H27g23YJH1PBOnZ1lmIB2T/w2+qFsKYgDj0awgWGdfc/ kGCHPn35cOys5ivlXzJrRoTfuc+HcHH928GdrrpN3k8NhHaFzfJDJdT4oB0fpAlTefVW xO+lBBgcdlVLN1OuT5oTVv3FIL8869r1mtC/NShJGmu/86uDnR8SSUZAkj+Y4Y0MUmPB AEU1hZWrGJW4mZ9ai6kaZtMAfmG/6RJEtNAhlyC/fbS8MSiaRUOY0twqx8p0rMGurFI3 T8lA== X-Gm-Message-State: AODbwcCHeKJgXF62GqFtlCuVIYcnTx0z1QaTaVOFd/Nr0ocCLJe7+uRG ScGLkVRV8E4Y7ZMR X-Received: by 10.99.97.215 with SMTP id v206mr29277013pgb.235.1495498406748; Mon, 22 May 2017 17:13:26 -0700 (PDT) Received: from mka.mtv.corp.google.com ([172.22.64.162]) by smtp.gmail.com with ESMTPSA id o66sm24909983pga.64.2017.05.22.17.13.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 May 2017 17:13:26 -0700 (PDT) From: Matthias Kaehlcke To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul Date: Mon, 22 May 2017 17:12:58 -0700 Message-Id: <20170523001258.81618-1-mka@chromium.org> X-Mailer: git-send-email 2.13.0.303.g4ebf302169-goog Cc: alsa-devel@alsa-project.org, Matthias Kaehlcke , linux-kernel@vger.kernel.org, Douglas Anderson Subject: [alsa-devel] [PATCH] ASoC: Intel: sst: Remove unused function sst_restore_shim64() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Looks like the function has never been used since it was added by commit b0d94acd634a ("ASoC: Intel: mrfld - add shim save restore"). Removing it fixes the following warning when building with clang: sound/soc/intel/atom/sst/sst.c:360:20: error: unused function 'sst_restore_shim64' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- sound/soc/intel/atom/sst/sst.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index f9ba71315e33..fb608d3a90c8 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -397,22 +397,6 @@ static inline void sst_save_shim64(struct intel_sst_drv *ctx, spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); } -static inline void sst_restore_shim64(struct intel_sst_drv *ctx, - void __iomem *shim, - struct sst_shim_regs64 *shim_regs) -{ - unsigned long irq_flags; - - /* - * we only need to restore IMRX for this case, rest will be - * initialize by FW or driver when firmware is loaded - */ - spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx); - sst_shim_write64(shim, SST_CSR, shim_regs->csr); - spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); -} - void sst_configure_runtime_pm(struct intel_sst_drv *ctx) { pm_runtime_set_autosuspend_delay(ctx->dev, SST_SUSPEND_DELAY);