From patchwork Fri Jun 9 16:50:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9778919 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 702E160350 for ; Fri, 9 Jun 2017 16:50:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67EC528655 for ; Fri, 9 Jun 2017 16:50:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C78528659; Fri, 9 Jun 2017 16:50:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A85B528655 for ; Fri, 9 Jun 2017 16:50:28 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 457A7267668; Fri, 9 Jun 2017 18:50:24 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 795CA26768D; Fri, 9 Jun 2017 18:50:23 +0200 (CEST) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by alsa0.perex.cz (Postfix) with ESMTP id 7070326765B for ; Fri, 9 Jun 2017 18:50:21 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id u26so9094242pfd.2 for ; Fri, 09 Jun 2017 09:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=dGA4c4TViKEOiQLN/QCqwmuYVP3pczJYRihz89i25MU=; b=SjyOqTuHp85wJNTZlNH2AVJrrBLmE/H2Y5NjEokST9CwsnfYqkKfGHNqHpewKWpBRp nIiKUSt4ng2HVhiLoAMYtbdexHHQhcg3YQvLZxGhLQekH+hEWiwl0sEIqm6PmFb0tRx9 GmOwUqswsHlUoHCrMgb27WngWFRN4HgOekI8vpBOmaIXAj5m/p++yDgyFMEbIkwJcFUz W1GNfYCJsdtQRHAuabyhwGd3KTTTdSnH1FIRQTAao4vVBpKrhagudYjWJcRn9SzGCW3W HBdTnHzwYNS4TBBr+DK1H6adz5vHe8q8e9JohfbuEgGBcIXYw0pyOZ6Fc+JWF4mL14Fr XSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=dGA4c4TViKEOiQLN/QCqwmuYVP3pczJYRihz89i25MU=; b=HEZnMl1DDsW+nl41osdRIsGwHWQxGpJ9RZP42sa490TnS1yTg5YICtLF3oH0PX/zyV Q+NUvpjROuVQjSxSOMzqPQyEV9SkktcP845UBQebgtCqAfuAKdrJbYNvN9+fzldDfCzw ahCQ0HDyhbtHFUDlzhdrG+oOMpQz0+RKYIfUQAesfEmWmMxhFAkmluty73lB2W42Qmh1 tWvZ0DLOrVmFQUEjvmuRbZI9MoCR6Q+9RLbPGfykd52csuwseaDo5oe0/Un/9BqA/Pwi IEnEWio0Q4Q1HXulBa3HC5kZOpqKgITLYd9lHfcVp8PBFXBF+JDe8EmKwd3vtrs0KRGi sqiA== X-Gm-Message-State: AODbwcC+ntwboIRtGDxbHpeJPEEtbUzH7eHkyta9Lpmo+X8kvrX5Rkqy u6TGNkCIyktCew== X-Received: by 10.84.218.71 with SMTP id f7mr40446604plm.180.1497027019643; Fri, 09 Jun 2017 09:50:19 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1311:81c1:46ea:ffcc:3c13]) by smtp.gmail.com with ESMTPSA id d19sm4694835pfd.35.2017.06.09.09.50.18 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 09 Jun 2017 09:50:19 -0700 (PDT) Date: Fri, 9 Jun 2017 09:50:17 -0700 From: Dmitry Torokhov To: Liam Girdwood , Mark Brown Message-ID: <20170609165017.GA2612@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: linux-kernel@vger.kernel.org, Nicolas Porcel , Takashi Iwai , alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH] ASoC: Intel: byt-max98090 Fix GPIOs lookup X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nicolas Porcel Commit 9c3c9bc9cc98 ("gpiolib: tighten up ACPI legacy gpio lookups") changed the way fallback to _CRS-defined GPIOs is executed by requiring drivers use common connection ID for all GPIOs fetched from _CRS. This broke byt-max98090 driver, which expected GPIO core to ignore the names it supplied and simply give GPIOs 0 and 1 from whatever block it finds. By giving the same name to both GPIOs 0 and 1, the driver will perform the lookup for both of them instead of the first requested. This is the same behavior than before the commit. Signed-off-by: Nicolas Porcel Signed-off-by: Dmitry Torokhov --- sound/soc/intel/boards/byt-max98090.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/byt-max98090.c b/sound/soc/intel/boards/byt-max98090.c index d9f81b8d915d..a6e57d95c1e2 100644 --- a/sound/soc/intel/boards/byt-max98090.c +++ b/sound/soc/intel/boards/byt-max98090.c @@ -67,13 +67,13 @@ static struct snd_soc_jack_pin hs_jack_pins[] = { static struct snd_soc_jack_gpio hs_jack_gpios[] = { { - .name = "hp-gpio", + .name = "byt_max98090", .idx = 0, .report = SND_JACK_HEADPHONE | SND_JACK_LINEOUT, .debounce_time = 200, }, { - .name = "mic-gpio", + .name = "byt_max98090", .idx = 1, .invert = 1, .report = SND_JACK_MICROPHONE,