diff mbox

[RESEND,v3,1/3] SoC: es8328-i2c: Add compatible for ES8323

Message ID 20170726135526.475-10-romain.perier@collabora.com (mailing list archive)
State New, archived
Headers show

Commit Message

Romain Perier July 26, 2017, 1:55 p.m. UTC
This commit adds a compatible string for everest,es8323. This is an
audio codec that is compatible with es8328 and can be found for example
on the Firefly-RK3288 board.

Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
 Documentation/devicetree/bindings/sound/es8328.txt | 5 ++++-
 sound/soc/codecs/es8328-i2c.c                      | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) Aug. 3, 2017, 7:01 p.m. UTC | #1
On Wed, Jul 26, 2017 at 03:55:24PM +0200, Romain Perier wrote:
> This commit adds a compatible string for everest,es8323. This is an
> audio codec that is compatible with es8328 and can be found for example
> on the Firefly-RK3288 board.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> ---
>  Documentation/devicetree/bindings/sound/es8328.txt | 5 ++++-
>  sound/soc/codecs/es8328-i2c.c                      | 2 ++
>  2 files changed, 6 insertions(+), 1 deletion(-)

I acked the previous v3 at the end of the discussion. Please add acks 
when posting new versions.

Acked-by: Rob Herring <robh@kernel.org>

Rob
Romain Perier Aug. 4, 2017, 6:44 a.m. UTC | #2
Le 03/08/2017 à 21:01, Rob Herring a écrit :
> On Wed, Jul 26, 2017 at 03:55:24PM +0200, Romain Perier wrote:
>> This commit adds a compatible string for everest,es8323. This is an
>> audio codec that is compatible with es8328 and can be found for example
>> on the Firefly-RK3288 board.
>>
>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>> ---
>>  Documentation/devicetree/bindings/sound/es8328.txt | 5 ++++-
>>  sound/soc/codecs/es8328-i2c.c                      | 2 ++
>>  2 files changed, 6 insertions(+), 1 deletion(-)
> I acked the previous v3 at the end of the discussion. Please add acks 
> when posting new versions.
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> Rob

My bad! Thanks

Romain
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/es8328.txt b/Documentation/devicetree/bindings/sound/es8328.txt
index 33fbf058c997..86b6d6e99732 100644
--- a/Documentation/devicetree/bindings/sound/es8328.txt
+++ b/Documentation/devicetree/bindings/sound/es8328.txt
@@ -4,7 +4,10 @@  This device supports both I2C and SPI.
 
 Required properties:
 
-  - compatible  : Should be "everest,es8328" or "everest,es8388"
+  - compatible  : Should be one of the following:
+	- "everest,es8323"
+	- "everest,es8328"
+	- "everest,es8388"
   - DVDD-supply : Regulator providing digital core supply voltage 1.8 - 3.6V
   - AVDD-supply : Regulator providing analog supply voltage 3.3V
   - PVDD-supply : Regulator providing digital IO supply voltage 1.8 - 3.6V
diff --git a/sound/soc/codecs/es8328-i2c.c b/sound/soc/codecs/es8328-i2c.c
index 318ab28c5351..be3f03c35137 100644
--- a/sound/soc/codecs/es8328-i2c.c
+++ b/sound/soc/codecs/es8328-i2c.c
@@ -19,6 +19,7 @@ 
 #include "es8328.h"
 
 static const struct i2c_device_id es8328_id[] = {
+	{ "es8323", 0 },
 	{ "es8328", 0 },
 	{ "es8388", 0 },
 	{ }
@@ -26,6 +27,7 @@  static const struct i2c_device_id es8328_id[] = {
 MODULE_DEVICE_TABLE(i2c, es8328_id);
 
 static const struct of_device_id es8328_of_match[] = {
+	{ .compatible = "everest,es8323", },
 	{ .compatible = "everest,es8328", },
 	{ .compatible = "everest,es8388", },
 	{ }