| Message ID | 20170728104216.26859-1-guneshwor.o.singh@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 60767abcea3dd1d47a4bd38398e1e8c1864975eb |
| Headers | show |
On Fri, Jul 28, 2017 at 04:12:13PM +0530, Guneshwor Singh wrote: > Controller can be in reset state by default. Capability structure > traversal requires the controller to be out of reset else it > results in broken capability parsing. Hence make sure that controller is > out of reset before parsing capabilities by doing a full reset. Good series and nice changelogs... Whole series: Acked-By: Vinod Koul <vinod.koul@intel.com>
diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 334917ee41cf..a56dfde3928c 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -702,6 +702,8 @@ static int skl_first_init(struct hdac_ext_bus *ebus) return -ENXIO; } + skl_init_chip(bus, true); + snd_hdac_bus_parse_capabilities(bus); if (skl_acquire_irq(ebus, 0) < 0)
Controller can be in reset state by default. Capability structure traversal requires the controller to be out of reset else it results in broken capability parsing. Hence make sure that controller is out of reset before parsing capabilities by doing a full reset. Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com> --- sound/soc/intel/skylake/skl.c | 2 ++ 1 file changed, 2 insertions(+)