| Message ID | 20170914010801.GA116841@lkp-g5.lkp.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi > sound/soc/soc-core.c:643:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > Fixes: 7e74acb4fc31 ("ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()") > CC: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
--- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -639,8 +639,7 @@ static struct snd_soc_pcm_runtime *soc_n static void soc_free_pcm_runtime(struct snd_soc_pcm_runtime *rtd) { - if (rtd->codec_dais) - kfree(rtd->codec_dais); + kfree(rtd->codec_dais); snd_soc_rtdcom_del_all(rtd); kfree(rtd); }
sound/soc/soc-core.c:643:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 7e74acb4fc31 ("ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()") CC: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- soc-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)