From patchwork Tue Jan 2 17:54:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10141141 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95C326034B for ; Tue, 2 Jan 2018 17:56:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83B2428C95 for ; Tue, 2 Jan 2018 17:56:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7887B28C9B; Tue, 2 Jan 2018 17:56:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A083F28C95 for ; Tue, 2 Jan 2018 17:56:41 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A2AB526742C; Tue, 2 Jan 2018 18:56:38 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B246B26742C; Tue, 2 Jan 2018 18:56:36 +0100 (CET) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by alsa0.perex.cz (Postfix) with ESMTP id DC148267429 for ; Tue, 2 Jan 2018 18:56:34 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r78so62773320wme.5 for ; Tue, 02 Jan 2018 09:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9KfIrzXGL6RxGMGKsM2UR04xV80qrASxe97H131V+7g=; b=dSGWMBs4AqHAeqgtieGOnQi3A2sEQkvHefJY2bXymg0rKiQrSSypiW9U9RresdWSkg LKAEW1PGCzsOPNoRCKifPHxRezj/lrHxRyo9dECV35RRJqmBF4ZnBIIgSRhjC3WqwFFF EHfP5WUi6weFMYZ42BI8zkihklCNZFVZN1ZiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9KfIrzXGL6RxGMGKsM2UR04xV80qrASxe97H131V+7g=; b=m8UO3huilkrgkJ5RZEs0JhpsmHRWcrANBuAzEa0wr4cwJrQiUfIhViG1CCQ415YCai 2op8doq+R0DEWznUd3prCIR9QssZL1ReQC8Y5fqqtI/+CA4Pjje++qXkpB50XJEjHoWo RDr1ZeMrh5ydVh/5GomqcJC+hoy0gQxqV7iZL1bfwuQgIRwwyZXEmsMDRCHRhjpoEkGV wNK3s6KyrpeoFOXb7VZR05CU5n3MjKnirGPEGx7BXPDp/LYEArxamp1UtHkDw2WPBTAy QQmnAj3SYaA3d2uhDhcKYG/kbBZnvS7PB04Niy6QhSA7mocTCe2GW6l88phHCZhB2hCE 9kWQ== X-Gm-Message-State: AKGB3mIqbRdOLQwrCXm10BekWW5IRtshetsgYu9XXDcPIl3OJhQxzxJS Z1UU288TmZihyRjSh2Ui8xNWdA== X-Google-Smtp-Source: ACJfBovQf/JsT5MJxxQC/eRBxiyWuPDotfxFjww+hf19OtT4lB3Z3wy0uvDy6b2IVlNh2oJ9irB59Q== X-Received: by 10.28.73.196 with SMTP id w187mr36493039wma.17.1514915794357; Tue, 02 Jan 2018 09:56:34 -0800 (PST) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id u54sm21895240wrf.77.2018.01.02.09.56.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Jan 2018 09:56:33 -0800 (PST) From: srinivas.kandagatla@linaro.org To: Greg Kroah-Hartman Date: Tue, 2 Jan 2018 17:54:19 +0000 Message-Id: <20180102175424.14391-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20180102175424.14391-1-srinivas.kandagatla@linaro.org> References: <20180102175424.14391-1-srinivas.kandagatla@linaro.org> Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , Colin Ian King , sdharia@codeaurora.org Subject: [alsa-devel] [PATCH 1/6] slimbus: avoid null pointer dereference on msg X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The pointer msg is checked to see if it is null at the start of the function and jumps to the error exit label reterr that then dereferences msg when it prints a dev_err error message. Avoid this potential null pointer dereference by only printing the error message if msg is not null. Detected by CoverityScan, CID#1463141 ("Dereference after null check") Signed-off-by: Colin Ian King Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 755462a4c75e..8b2c77f516b9 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -170,8 +170,9 @@ static int slim_val_inf_sanity(struct slim_controller *ctrl, break; } reterr: - dev_err(ctrl->dev, "Sanity check failed:msg:offset:0x%x, mc:%d\n", - msg->start_offset, mc); + if (msg) + dev_err(ctrl->dev, "Sanity check failed:msg:offset:0x%x, mc:%d\n", + msg->start_offset, mc); return -EINVAL; }