| Message ID | 20180208143530.11450-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 29c5b8fd8c07a42b07383c5fac47173d882f74b2 |
| Headers | show |
Hi, On Feb 8 2018 23:35, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function skl_clk_round_rate is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol > 'skl_clk_round_rate' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c > index 7fbddf5e3b00..cda1b5fa7436 100644 > --- a/sound/soc/intel/skylake/skl-ssp-clk.c > +++ b/sound/soc/intel/skylake/skl-ssp-clk.c > @@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw, > } > > /* Not supported by clk driver. Implemented to satisfy clk fw */ > -long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *parent_rate) > +static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long *parent_rate) > { > return rate; > } Thanks Takashi Sakamoto
On Thu, Feb 08, 2018 at 02:35:30PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function skl_clk_round_rate is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol > 'skl_clk_round_rate' was not declared. Should it be static? Acked-By: Vinod Koul <vinod.koul@intel.com>
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c index 7fbddf5e3b00..cda1b5fa7436 100644 --- a/sound/soc/intel/skylake/skl-ssp-clk.c +++ b/sound/soc/intel/skylake/skl-ssp-clk.c @@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw, } /* Not supported by clk driver. Implemented to satisfy clk fw */ -long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate, + unsigned long *parent_rate) { return rate; }