From patchwork Tue Feb 27 20:33:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirill Marinushkin X-Patchwork-Id: 10246017 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1FA2460362 for ; Tue, 27 Feb 2018 20:33:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EB30289C5 for ; Tue, 27 Feb 2018 20:33:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0236A28A1B; Tue, 27 Feb 2018 20:33:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E8DF289C5 for ; Tue, 27 Feb 2018 20:33:41 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 76B01267729; Tue, 27 Feb 2018 21:33:36 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B6A6626772A; Tue, 27 Feb 2018 21:33:33 +0100 (CET) Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by alsa0.perex.cz (Postfix) with ESMTP id 841B8267727 for ; Tue, 27 Feb 2018 21:33:30 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id s5so141618wra.0 for ; Tue, 27 Feb 2018 12:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y0RMn0f8gSrmIHqnNw7aCQC6Om4lsGLXXnhXT6wufdA=; b=plSGxM506Y/muNlolNEYCdk6tBkWraoviPZTll/i6J+rHZyt1HV6UzvzoKimP6nI5d 4U2xfAnxN+LN0bXwMBcwzi5scW3sQipysILBwgCKZTHrrhtsH4KClbjJaYQ3otS76Fve yU4WsK9JhNnR3ioNdkSpKcpPty5DgdGKxLb0NGiYXg88CxwwRNP+Hg/gif9IabxiQWmU 3qGeAnU9O0Twed1EGQuEwOLMVyy2iFpAFCzidd3iU5kbh3Sekuc19Ec/SP1DrKbmSxUO jOE0pi1IjjrgU/oQeWl0ADdUhCwDShlgkG8oiOhW5WD/ToiqsvGVkoymAZon0ghquz4g EG4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Y0RMn0f8gSrmIHqnNw7aCQC6Om4lsGLXXnhXT6wufdA=; b=gMAyamNfxMGeorx4pj5wLIUoysATmbXxJ1oz+04SwgOO0CHA2NFvcmBjfTPhtJZE6F xIw++OxAiUWQSkk7acQ/XYtXlMEij8ACn7V8IhQZDqLcxRP7hrxgklTMewXZmTtW1ddG 8Bs4u5agxVoAx8Tor73YxWtJzRL8qy5OyRzBxU8fQANKNfQdnhefntJUZTiDNKx+ODWD 8VdvPVoGNa2iVJXkmj0c8VMKGhcgvhRv/uJ+/QHGItzt2aGXr8icecBqH9QIqGHpH/wB zFTSkYoV6Mt7lxB22pFt2ARDkTaAq2G/S/wkz28q5oVyQdcI3tGFj+fNw0AjOPDlyoGd 68kg== X-Gm-Message-State: APf1xPDiP95wrCcEGWn69kRxTgAxCdxkMQ9nco3TW7toBybH3s+yuhib uzEj99yC3s7fZ8EC3/CuRZY= X-Google-Smtp-Source: AG47ELs2YE6bG5PaJ8d3IcX0akbCTFpKQt1LTp4PBMfK7U/Ws0B6v6DJFXbAykTomEECmdg5s4kyLg== X-Received: by 10.223.133.70 with SMTP id 64mr2643190wrh.164.1519763609789; Tue, 27 Feb 2018 12:33:29 -0800 (PST) Received: from gentoo0.localdomain (x4e34ba44.dyn.telefonica.de. [78.52.186.68]) by smtp.gmail.com with ESMTPSA id z73sm447922wmc.3.2018.02.27.12.33.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 12:33:29 -0800 (PST) From: Kirill Marinushkin To: Mark Brown Date: Tue, 27 Feb 2018 21:33:17 +0100 Message-Id: <20180227203317.17274-2-k.marinushkin@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180227203317.17274-1-k.marinushkin@gmail.com> References: <20180227155758.GD11822@sirena.org.uk> <20180227203317.17274-1-k.marinushkin@gmail.com> Cc: alsa-devel@alsa-project.org, Pan Xiuli , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Kirill Marinushkin Subject: [alsa-devel] [PATCH 1/1] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The values of bclk and fsync are inverted WRT the codec. But the existing solution already works for Broadwell, see the alsa-lib config: `alsa-lib/src/conf/topology/broadwell/broadwell.conf` This commit provides the backwards-compatible solution to fix this misuse. This commit goes in pair with the corresponding patch for alsa-lib. Signed-off-by: Kirill Marinushkin Cc: Mark Brown Cc: Pierre-Louis Bossart Cc: Pan Xiuli Cc: Liam Girdwood Cc: linux-kernel@vger.kernel.org Cc: alsa-devel@alsa-project.org --- include/uapi/sound/asoc.h | 16 ++++++++++++++-- sound/soc/soc-topology.c | 12 +++++++----- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h index 69c37ecbff7e..f0e5e21efa54 100644 --- a/include/uapi/sound/asoc.h +++ b/include/uapi/sound/asoc.h @@ -160,6 +160,18 @@ #define SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_SAMPLEBITS (1 << 2) #define SND_SOC_TPLG_LNK_FLGBIT_VOICE_WAKEUP (1 << 3) +/* DAI topology BCLK parameter + * For the backwards capability, by default codec is bclk master + */ +#define SND_SOC_TPLG_BCLK_CM 0 /* codec is bclk master */ +#define SND_SOC_TPLG_BCLK_CS 1 /* codec is bclk slave */ + +/* DAI topology FSYNC parameter + * For the backwards capability, by default codec is fsync master + */ +#define SND_SOC_TPLG_FSYNC_CM 0 /* codec is fsync master */ +#define SND_SOC_TPLG_FSYNC_CS 1 /* codec is fsync slave */ + /* * Block Header. * This header precedes all object and object arrays below. @@ -315,8 +327,8 @@ struct snd_soc_tplg_hw_config { __u8 clock_gated; /* 1 if clock can be gated to save power */ __u8 invert_bclk; /* 1 for inverted BCLK, 0 for normal */ __u8 invert_fsync; /* 1 for inverted frame clock, 0 for normal */ - __u8 bclk_master; /* 1 for master of BCLK, 0 for slave */ - __u8 fsync_master; /* 1 for master of FSYNC, 0 for slave */ + __u8 bclk_master; /* SND_SOC_TPLG_BCLK_ value */ + __u8 fsync_master; /* SND_SOC_TPLG_FSYNC_ value */ __u8 mclk_direction; /* 0 for input, 1 for output */ __le16 reserved; /* for 32bit alignment */ __le32 mclk_rate; /* MCLK or SYSCLK freqency in Hz */ diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 01a50413c66f..c5bdc673b195 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1994,13 +1994,15 @@ static void set_link_hw_format(struct snd_soc_dai_link *link, link->dai_fmt |= SND_SOC_DAIFMT_IB_IF; /* clock masters */ - bclk_master = hw_config->bclk_master; - fsync_master = hw_config->fsync_master; - if (!bclk_master && !fsync_master) + bclk_master = (hw_config->bclk_master == + SND_SOC_TPLG_BCLK_CM); + fsync_master = (hw_config->fsync_master == + SND_SOC_TPLG_FSYNC_CM); + if (bclk_master && fsync_master) link->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM; - else if (bclk_master && !fsync_master) - link->dai_fmt |= SND_SOC_DAIFMT_CBS_CFM; else if (!bclk_master && fsync_master) + link->dai_fmt |= SND_SOC_DAIFMT_CBS_CFM; + else if (bclk_master && !fsync_master) link->dai_fmt |= SND_SOC_DAIFMT_CBM_CFS; else link->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;