| Message ID | 20180411124238.9385-2-peda@axentia.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 11, 2018 at 02:42:38PM +0200, Peter Rosin wrote:
> Use the new probe style for i2c drivers.
This doesn't apply against current code, please check and resend.
On 2018-04-12 18:16, Mark Brown wrote: > On Wed, Apr 11, 2018 at 02:42:38PM +0200, Peter Rosin wrote: > >> Use the new probe style for i2c drivers. > This doesn't apply against current code, please check and resend. That's not my fault. Somebody forgot to drop a note with the maintainer so I was completely unaware of this change. It seems to have been a cocci-script or something behind that change because the code looks like shit afterwards. For the record, I wish to be on Cc for changes to files I maintain. That is one of the core functions of the MAINTAINERS file, right? Anyway, I added a couple of fixups for that mess and I also did a SPDX conversion while at it since I noticed it was needed. Finishing off with the rebased patch. Cheers, Peter Peter Rosin (5): ASoC: max9860: fix whitespace issues caused by mindless conversion ASoC: tfa9879: fix whitespace issues caused by mindless conversion ASoC: max9860: switch to SPDX license tag ASoC: tfa9879: switch to SPDX license tag ASoC: tfa9879: switch to using .probe_new sound/soc/codecs/max9860.c | 18 ++++++------------ sound/soc/codecs/max9860.h | 10 +--------- sound/soc/codecs/tfa9879.c | 37 ++++++++++++++++--------------------- sound/soc/codecs/tfa9879.h | 7 +------ 4 files changed, 24 insertions(+), 48 deletions(-)
On Thu, Apr 12, 2018 at 11:14:32PM +0200, Peter Rosin wrote: > For the record, I wish to be on Cc for changes to files I maintain. > That is one of the core functions of the MAINTAINERS file, right? Right, people should do that but it's not 100% reliable unfortunately. It's not unknown for people to wonder why I've not reviewed patches they didn't send me :(
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index e7ca764b5729..15c769528d6d 100644 --- a/sound/soc/codecs/tfa9879.c +++ b/sound/soc/codecs/tfa9879.c @@ -274,8 +274,7 @@ static struct snd_soc_dai_driver tfa9879_dai = { .ops = &tfa9879_dai_ops, }; -static int tfa9879_i2c_probe(struct i2c_client *i2c, - const struct i2c_device_id *id) +static int tfa9879_i2c_probe(struct i2c_client *i2c) { struct tfa9879_priv *tfa9879; int i; @@ -323,7 +322,7 @@ static struct i2c_driver tfa9879_i2c_driver = { .name = "tfa9879", .of_match_table = tfa9879_of_match, }, - .probe = tfa9879_i2c_probe, + .probe_new = tfa9879_i2c_probe, .remove = tfa9879_i2c_remove, .id_table = tfa9879_i2c_id, };
Use the new probe style for i2c drivers. Signed-off-by: Peter Rosin <peda@axentia.se> --- sound/soc/codecs/tfa9879.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)