diff mbox

[v2,2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3.

Message ID 20180424172445.31928-3-jorge.sanjuan@codethink.co.uk
State New, archived
Headers show

Commit Message

Jorge Sanjuan April 24, 2018, 5:24 p.m. UTC
From: Michael Drake <michael.drake@codethink.co.uk>

The channel mapping is defined by bChRelationship, not bChPurpose.

Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0
support")
Reviewed-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>
---
 sound/usb/stream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai April 24, 2018, 5:55 p.m. UTC | #1
On Tue, 24 Apr 2018 19:24:43 +0200,
Jorge Sanjuan wrote:
> 
> From: Michael Drake <michael.drake@codethink.co.uk>
> 
> The channel mapping is defined by bChRelationship, not bChPurpose.
> 
> Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0
> support")
> Reviewed-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
> Signed-off-by: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>

Applied this to for-linus branch now, as it's a clear fix.


thanks,

Takashi
diff mbox

Patch

diff --git a/sound/usb/stream.c b/sound/usb/stream.c
index 6a8f5843334e..956be9f7c72a 100644
--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -349,7 +349,7 @@  snd_pcm_chmap_elem *convert_chmap_v3(struct uac3_cluster_header_descriptor
 			 * TODO: this conversion is not complete, update it
 			 * after adding UAC3 values to asound.h
 			 */
-			switch (is->bChPurpose) {
+			switch (is->bChRelationship) {
 			case UAC3_CH_MONO:
 				map = SNDRV_CHMAP_MONO;
 				break;