alsa plugins + slibtool

Commit Message

[e-mail] May 18, 2018, 3:14 p.m. UTC

Hi,

I am experiencing build issues with alsa-plugins when using slibtool
instead of libtool. This build issue is because of a bug in
alsa-plugins which libtool hides so I have attached a log showing the
build error and a small patch to solve it. This patch will require
regenerating the autotools files with a command like 'autoreconf -fi'
to take effect.

If this could be applied in the next alsa-plugins release I would be
very grateful. Also note that I have tried to send this patch to the
mailing list before and am unsure if it ever made it past moderation?

For reference here is a link to the slibtool source.

https://git.midipix.org/cgit.cgi/slibtool/

And to their README that explains the project.

https://git.midipix.org/cgit.cgi/slibtool/plain/README

Thanks,
Hunter

Comments

Takashi Iwai May 22, 2018, 12:18 p.m. UTC | #1

On Fri, 18 May 2018 17:14:37 +0200,
[e-mail] wrote:
> 
> Hi,
> 
> I am experiencing build issues with alsa-plugins when using slibtool
> instead of libtool. This build issue is because of a bug in
> alsa-plugins which libtool hides so I have attached a log showing the
> build error and a small patch to solve it. This patch will require
> regenerating the autotools files with a command like 'autoreconf -fi'
> to take effect.
> 
> If this could be applied in the next alsa-plugins release I would be
> very grateful. Also note that I have tried to send this patch to the
> mailing list before and am unsure if it ever made it past moderation?
> 
> For reference here is a link to the slibtool source.
> 
> https://git.midipix.org/cgit.cgi/slibtool/
> 
> And to their README that explains the project.
> 
> https://git.midipix.org/cgit.cgi/slibtool/plain/README
> 
> Thanks,
> Hunter
> diff -ur alsa-plugins-1.1.5/arcam-av/Makefile.am alsa-plugins-1.1.5/arcam-av/Makefile.am
> --- alsa-plugins-1.1.5/arcam-av/Makefile.am	2017-11-13 23:52:10.000000000 -0800
> +++ alsa-plugins-1.1.5/arcam-av/Makefile.am	2017-11-29 15:19:56.025415638 -0800
> @@ -3,7 +3,7 @@
>  asound_module_ctl_arcam_avdir = @ALSA_PLUGIN_DIR@
>  
>  AM_CFLAGS = -Wall -g @ALSA_CFLAGS@
> -AM_LDFLAGS = -module -avoid-version -export-dynamic -no-undefined
> +AM_LDFLAGS = -module -avoid-version -export-dynamic -no-undefined -pthread
>  
>  libasound_module_ctl_arcam_av_la_SOURCES = ctl_arcam_av.c arcam_av.c arcam_av.h
>  libasound_module_ctl_arcam_av_la_LIBADD = @ALSA_LIBS@

The -lpthread should be added *_LIBADD instead.
Fixed in git repo now.  Thanks for reporting.


Takashi

Patch

diff -ur alsa-plugins-1.1.5/arcam-av/Makefile.am alsa-plugins-1.1.5/arcam-av/Makefile.am
--- alsa-plugins-1.1.5/arcam-av/Makefile.am	2017-11-13 23:52:10.000000000 -0800
+++ alsa-plugins-1.1.5/arcam-av/Makefile.am	2017-11-29 15:19:56.025415638 -0800
@@ -3,7 +3,7 @@ 
 asound_module_ctl_arcam_avdir = @ALSA_PLUGIN_DIR@
 
 AM_CFLAGS = -Wall -g @ALSA_CFLAGS@
-AM_LDFLAGS = -module -avoid-version -export-dynamic -no-undefined
+AM_LDFLAGS = -module -avoid-version -export-dynamic -no-undefined -pthread
 
 libasound_module_ctl_arcam_av_la_SOURCES = ctl_arcam_av.c arcam_av.c arcam_av.h
 libasound_module_ctl_arcam_av_la_LIBADD = @ALSA_LIBS@