diff mbox

ASoC: dapm: update function comments

Message ID 20180606160736.169077-1-tzungbi@google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tzung-Bi Shih June 6, 2018, 4:07 p.m. UTC 
snd_soc_dapm_put_volsw() and snd_soc_dapm_put_enum_double() returns
0 if the value is unchanged and 1 if changed. Both 0 and 1 indicate
a success.

Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
---
 sound/soc/soc-dapm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Charles Keepax June 7, 2018, 12:48 p.m. UTC | #1 
On Thu, Jun 07, 2018 at 12:07:36AM +0800, Tzung-Bi Shih wrote:
> snd_soc_dapm_put_volsw() and snd_soc_dapm_put_enum_double() returns
> 0 if the value is unchanged and 1 if changed. Both 0 and 1 indicate
> a success.
> 
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
diff mbox

Patch

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 2d9709104ec5..9843086dc1ed 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3178,7 +3178,7 @@  EXPORT_SYMBOL_GPL(snd_soc_dapm_get_volsw);
  *
  * Callback to set the value of a dapm mixer control.
  *
- * Returns 0 for success.
+ * Returns either 0 or 1 for success: 1 if changed, 0 if unchanged.
  */
 int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_value *ucontrol)
@@ -3311,7 +3311,7 @@  EXPORT_SYMBOL_GPL(snd_soc_dapm_get_enum_double);
  *
  * Callback to set the value of a dapm enumerated double mixer control.
  *
- * Returns 0 for success.
+ * Returns either 0 or 1 for success: 1 if changed, 0 if unchanged.
  */
 int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_value *ucontrol)