diff mbox

ALSA: lx6464es: Missing error code in snd_lx6464es_create()

Message ID 20180620204256.wvesr47qgikwhfgq@kili.mountain (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter June 21, 2018, 8:07 a.m. UTC 
We forgot to set the error code on this error path.

Fixes: 4a23fc8cc068 ("ALSA: lx6464es: add error handling for pci_ioremap_bar")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Takashi Iwai June 21, 2018, 9:04 a.m. UTC | #1 
On Thu, 21 Jun 2018 10:07:21 +0200,
Dan Carpenter wrote:
> 
> We forgot to set the error code on this error path.
> 
> Fixes: 4a23fc8cc068 ("ALSA: lx6464es: add error handling for pci_ioremap_bar")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi
diff mbox

Patch

diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
index 6c85f13ab23f..54f6252faca6 100644
--- a/sound/pci/lx6464es/lx6464es.c
+++ b/sound/pci/lx6464es/lx6464es.c
@@ -1018,6 +1018,7 @@  static int snd_lx6464es_create(struct snd_card *card,
 	chip->port_dsp_bar = pci_ioremap_bar(pci, 2);
 	if (!chip->port_dsp_bar) {
 		dev_err(card->dev, "cannot remap PCI memory region\n");
+		err = -ENOMEM;
 		goto remap_pci_failed;
 	}