diff mbox

ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

Message ID 20180701093023.6872-1-hdegoede@redhat.com (mailing list archive)
State Accepted
Commit 9ee6f8a8cbbd203fb0a844f937007a9525422697
Headers show

Commit Message

Hans de Goede July 1, 2018, 9:30 a.m. UTC
Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
mono-speaker. Otherwise it works fine with the defaults.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Mark Brown July 18, 2018, 11:25 a.m. UTC | #1
On Sun, Jul 01, 2018 at 11:30:23AM +0200, Hans de Goede wrote:
> Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
> mono-speaker. Otherwise it works fine with the defaults.

Did this get rolled up into some other series?
Hans de Goede July 18, 2018, 12:54 p.m. UTC | #2
Hi,

On 18-07-18 13:25, Mark Brown wrote:
> On Sun, Jul 01, 2018 at 11:30:23AM +0200, Hans de Goede wrote:
>> Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
>> mono-speaker. Otherwise it works fine with the defaults.
> 
> Did this get rolled up into some other series?

No this patch is still pending / waiting for you to merge it.

Regards,

Hans
Mark Brown July 18, 2018, 2:49 p.m. UTC | #3
On Wed, Jul 18, 2018 at 02:54:32PM +0200, Hans de Goede wrote:
> On 18-07-18 13:25, Mark Brown wrote:
> > On Sun, Jul 01, 2018 at 11:30:23AM +0200, Hans de Goede wrote:
> > > Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
> > > mono-speaker. Otherwise it works fine with the defaults.

> > Did this get rolled up into some other series?

> No this patch is still pending / waiting for you to merge it.

I'm still waiting for Pierre to review it so...
Pierre-Louis Bossart July 18, 2018, 8:36 p.m. UTC | #4
On 07/01/2018 04:30 AM, Hans de Goede wrote:
> Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
> mono-speaker. Otherwise it works fine with the defaults.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Sorry about the delay, I missed this patch.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 7456566c5648..718f022b3aa0 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   		},
>   		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
>   	},
> +	{	/* Connect Tablet 9 */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
> +		},
> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> +					BYT_RT5640_MONO_SPEAKER |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{
>   		.matches = {
>   			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
diff mbox

Patch

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 7456566c5648..718f022b3aa0 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -486,6 +486,16 @@  static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 		},
 		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
 	},
+	{	/* Connect Tablet 9 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
+		},
+		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+					BYT_RT5640_MONO_SPEAKER |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
+	},
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),