diff mbox

[04/14] conf/ucm: bytcr-rt5651: Configure all volumes at 0dB

Message ID 20180720072741.4632-5-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hans de Goede July 20, 2018, 7:27 a.m. UTC
The volumes are taken from this commit:
https://github.com/plbossart/UCM/commit/753e2430cd0e6cafbf10c6b29b689dbd32ac5250

That commit also adds line-in support, so it has not been
taken in its entirety.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Pierre-Louis Bossart July 20, 2018, 1:48 p.m. UTC | #1
On 7/20/18 2:27 AM, Hans de Goede wrote:
> The volumes are taken from this commit:
> https://github.com/plbossart/UCM/commit/753e2430cd0e6cafbf10c6b29b689dbd32ac5250
> 
> That commit also adds line-in support, so it has not been
> taken in its entirety.

Was there anything wrong with the line-in? It's been a while and I fried 
my board but I think it worked ok. The settings came from Bard Liao.

> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf b/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
> index 5dcb11e6..d6e8e48d 100644
> --- a/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
> +++ b/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
> @@ -117,16 +117,13 @@ SectionDefaults [
>   	cset "name='sprot_loop_out mix 0 sprot_loop_in Switch' off"
>   
>   	# default state
> -	cset "name='ADC Capture Volume' 126"
>   	cset "name='HPO MIX DAC1 Switch' on"
>   	cset "name='HPO MIX HPVOL Switch' off"
> -	cset "name='HP Playback Volume' 0"
>   	cset "name='HPO L Playback Switch' off"
>   	cset "name='HPO R Playback Switch' off"
>   	cset "name='HPOVOL L Switch' on"
>   	cset "name='HPOVOL R Switch' on"
>   	cset "name='IF1 ASRC Switch' on"
> -	cset "name='IN Capture Volume' 27"
>   	cset "name='IN2 Boost' 1"
>   	cset "name='IN1 Boost' 1"
>   	cset "name='LOUT L Playback Switch' on"
> @@ -145,6 +142,13 @@ SectionDefaults [
>   	cset "name='Headphone Switch' off"
>   	cset "name='Speaker Switch' off"
>   
> +	# volumes for 0dB
> +	cset "name='OUT Playback Volume' 31"
> +	cset "name='HP Playback Volume' 31"
> +	cset "name='IN Capture Volume' 23"
> +	cset "name='ADC Capture Volume' 47"
> +	cset "name='DAC1 Playback Volume' 175"
> +
>   	# input
>   	cset "name='Stereo1 ADC L1 Mux' ADC"
>   	cset "name='Stereo1 ADC R1 Mux' ADC"
>
Hans de Goede Aug. 8, 2018, 9:02 a.m. UTC | #2
Hi Pierre-Louis,

Thank you for the reviews.

On 20-07-18 15:48, Pierre-Louis Bossart wrote:
> On 7/20/18 2:27 AM, Hans de Goede wrote:
>> The volumes are taken from this commit:
>> https://github.com/plbossart/UCM/commit/753e2430cd0e6cafbf10c6b29b689dbd32ac5250
>>
>> That commit also adds line-in support, so it has not been
>> taken in its entirety.
> 
> Was there anything wrong with the line-in? It's been a while and I fried my board but I think it worked ok. The settings came from Bard Liao.

I don't have any devices with a line-in so I could not test,
also line-in support really should be added in a different
commit and mixed in with the 0Db changes.

I believe it is best if someone who can actually test this
adds line-in support on top of this series.

Regards,

Hans



> 
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf b/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
>> index 5dcb11e6..d6e8e48d 100644
>> --- a/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
>> +++ b/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
>> @@ -117,16 +117,13 @@ SectionDefaults [
>>       cset "name='sprot_loop_out mix 0 sprot_loop_in Switch' off"
>>       # default state
>> -    cset "name='ADC Capture Volume' 126"
>>       cset "name='HPO MIX DAC1 Switch' on"
>>       cset "name='HPO MIX HPVOL Switch' off"
>> -    cset "name='HP Playback Volume' 0"
>>       cset "name='HPO L Playback Switch' off"
>>       cset "name='HPO R Playback Switch' off"
>>       cset "name='HPOVOL L Switch' on"
>>       cset "name='HPOVOL R Switch' on"
>>       cset "name='IF1 ASRC Switch' on"
>> -    cset "name='IN Capture Volume' 27"
>>       cset "name='IN2 Boost' 1"
>>       cset "name='IN1 Boost' 1"
>>       cset "name='LOUT L Playback Switch' on"
>> @@ -145,6 +142,13 @@ SectionDefaults [
>>       cset "name='Headphone Switch' off"
>>       cset "name='Speaker Switch' off"
>> +    # volumes for 0dB
>> +    cset "name='OUT Playback Volume' 31"
>> +    cset "name='HP Playback Volume' 31"
>> +    cset "name='IN Capture Volume' 23"
>> +    cset "name='ADC Capture Volume' 47"
>> +    cset "name='DAC1 Playback Volume' 175"
>> +
>>       # input
>>       cset "name='Stereo1 ADC L1 Mux' ADC"
>>       cset "name='Stereo1 ADC R1 Mux' ADC"
>>
>
diff mbox

Patch

diff --git a/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf b/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
index 5dcb11e6..d6e8e48d 100644
--- a/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
+++ b/src/conf/ucm/bytcr-rt5651/bytcr-rt5651.conf
@@ -117,16 +117,13 @@  SectionDefaults [
 	cset "name='sprot_loop_out mix 0 sprot_loop_in Switch' off"
 
 	# default state
-	cset "name='ADC Capture Volume' 126"
 	cset "name='HPO MIX DAC1 Switch' on"
 	cset "name='HPO MIX HPVOL Switch' off"
-	cset "name='HP Playback Volume' 0"
 	cset "name='HPO L Playback Switch' off"
 	cset "name='HPO R Playback Switch' off"
 	cset "name='HPOVOL L Switch' on"
 	cset "name='HPOVOL R Switch' on"
 	cset "name='IF1 ASRC Switch' on"
-	cset "name='IN Capture Volume' 27"
 	cset "name='IN2 Boost' 1"
 	cset "name='IN1 Boost' 1"
 	cset "name='LOUT L Playback Switch' on"
@@ -145,6 +142,13 @@  SectionDefaults [
 	cset "name='Headphone Switch' off"
 	cset "name='Speaker Switch' off"
 
+	# volumes for 0dB
+	cset "name='OUT Playback Volume' 31"
+	cset "name='HP Playback Volume' 31"
+	cset "name='IN Capture Volume' 23"
+	cset "name='ADC Capture Volume' 47"
+	cset "name='DAC1 Playback Volume' 175"
+
 	# input
 	cset "name='Stereo1 ADC L1 Mux' ADC"
 	cset "name='Stereo1 ADC R1 Mux' ADC"