From patchwork Fri Jul 20 08:04:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 10536185 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B9CA6029B for ; Fri, 20 Jul 2018 08:04:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B3962961B for ; Fri, 20 Jul 2018 08:04:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F24C62962D; Fri, 20 Jul 2018 08:04:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6137C2961B for ; Fri, 20 Jul 2018 08:04:56 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BF743267759; Fri, 20 Jul 2018 10:04:50 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B1B7826772E; Fri, 20 Jul 2018 10:04:46 +0200 (CEST) Received: from mout.perfora.net (mout.perfora.net [74.208.4.196]) by alsa0.perex.cz (Postfix) with ESMTP id C53A7267711 for ; Fri, 20 Jul 2018 10:04:44 +0200 (CEST) Received: from localhost.localdomain.ziswiler.net ([89.217.215.226]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0M0SMt-1g0yzf2D6r-00udhf; Fri, 20 Jul 2018 10:04:35 +0200 From: Marcel Ziswiler To: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org Date: Fri, 20 Jul 2018 10:04:23 +0200 Message-Id: <20180720080424.31505-1-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.4 X-Provags-ID: V03:K1:bxEoqQmibD/NUR4afCiYg8b5ZXqz8NK2vFQb3gMon70TjzZrHQ4 +yQelCMZ3wo5BAsH0/v4oQFWUG+oDMZ1MQ1dLYoCQeM3/3CyybrtqVExDXBvbsggVD+7RUL s7pnV/JTnFG0BdkGNzayA9EuIQ1moVpLMPbKAmC0ZhLIAESY34IFTjCRWrQNAA8ILbdEXYB lJNGmv3rnj5hiMI1PJIfA== X-UI-Out-Filterresults: notjunk:1; V01:K0:+m9PrdckY8U=:67vIO9I0zDvCshXSs0uO05 PIaXzTiKcr3ieip3050S7KGUHd8hSFRmaFFHKrtsoFVqDiottJcMi6FMPy4SjOHH98/i+K4Q7 YOLZPFHvLIlPLvI8i2Rv/xesHxv6YiUXCfh4ly6ODqrc6Xbkubj64mApR9Omvnyk8mt/ivoYL Odt/tdiccxYmMltTv1WsFqsRLNJNI4FuUcAMxsda1C0/gqNeYns0yYepvAWjO9h3WlMV8agbh NX0WbxN0rBYl1hwgBs23Mbxb+AVJpDj2Dp8WlOE3xT24a7xBepa3a1qgJTMn1iEZlb49NRGfC Y3EHx/5zwitm5zoHAAu9xWp7DuUCaG45xWP7+2mjadusYjrV1BDx2y2ljX45V3RFCnayrXwzZ cEufQWOE19f40B2SAqtVMSXFiemU9/JDIp/4f6plTQd1VxNn71Z1F8xw19vPnDYua+6XRUamO lFk6nMSxE3X5ZPmlodtPCgMW8g1JtZPwNGwJ8x4d8ms7Odb0dpALPmcsYkVP7pgUPfsf2bOAL 7ZFJR1pjjJWIUuoJTLVB2cck/LMEDsB7fFqzXQOXy50ZgwS4StTntWiWweiJvn5oxJARjrokU oRxGK76NtyWYBwFjvIXPtvHSh/EoPa42f98jTPOi6DaAfa84RZ1lL44857Z+xxihAkXvXmOFP pAIqcAIAwvi7+3cE6YUBrROfJRbAInBGuouKtZvVSDtmf/Pog2BYfwrp466pmmigHKOs= Cc: Liam Girdwood , Marcel Ziswiler , Takashi Iwai , linux-kernel@vger.kernel.org, Jonathan Hunter , Mark Brown , Thierry Reding Subject: [alsa-devel] [PATCH 1/2] ASoC: tegra: improve goto error label X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Marcel Ziswiler While the two error labels "err" and "err_clk_put" goto the same place it is rather confusing that the earlier one is certainly used later again. Signed-off-by: Marcel Ziswiler --- sound/soc/tegra/tegra20_ac97.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c index affad46bf188..682ef33afb5f 100644 --- a/sound/soc/tegra/tegra20_ac97.c +++ b/sound/soc/tegra/tegra20_ac97.c @@ -377,7 +377,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) ret = clk_prepare_enable(ac97->clk_ac97); if (ret) { dev_err(&pdev->dev, "clk_enable failed: %d\n", ret); - goto err; + goto err_clk_put; } ret = snd_soc_set_ac97_ops(&tegra20_ac97_ops);