diff mbox series

[04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

Message ID 20180723155410.9494-5-srinivas.kandagatla@linaro.org (mailing list archive)
State New, archived
Headers show
Series mfd: Add support to WCD9335 Audio Codec | expand

Commit Message

Srinivas Kandagatla July 23, 2018, 3:54 p.m. UTC 
This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
and I2S/I2C interface.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 .../devicetree/bindings/sound/qcom,wcd9335.txt      | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd9335.txt

Comments

Mark Brown July 24, 2018, 11:06 a.m. UTC | #1 
On Mon, Jul 23, 2018 at 04:54:02PM +0100, Srinivas Kandagatla wrote:
> This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
> and I2S/I2C interface.

...

> +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
> +It supports both I2S/I2C and SLIMbus audio interfaces.

This is a standalone audio CODEC but it also has a MFD binding?  I'd
have just expected a single binding for a single device.
Srinivas Kandagatla July 24, 2018, 11:48 a.m. UTC | #2 
On 24/07/18 12:06, Mark Brown wrote:
> On Mon, Jul 23, 2018 at 04:54:02PM +0100, Srinivas Kandagatla wrote:
>> This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
>> and I2S/I2C interface.
> 
> ...
> 
>> +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
>> +It supports both I2S/I2C and SLIMbus audio interfaces.
> 
> This is a standalone audio CODEC but it also has a MFD binding?  I'd
> have just expected a single binding for a single device.
> 
Thanks for the suggestion!

You are right, I should probably remove the mfd bindings totally.
and move them to codec bindings. And register codec and other blocks 
like soundwire controller as mfd cells. like wm8994.

--srini
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
new file mode 100644
index 000000000000..55fcf7504fe1
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
@@ -0,0 +1,21 @@ 
+QCOM WCD9335 Audio Codec
+
+Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
+It supports both I2S/I2C and SLIMbus audio interfaces.
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: "qcom,wcd9335-codec"
+
+- #sound-dai-cells
+	Usage: required
+	Value type: <u32>
+	Definition: Must be 1
+
+= EXAMPLE
+
+codec {
+	compatible = "qcom,wcd9335-codec";
+	#sound-dai-cells = <1>;
+};