From patchwork Fri Jul 27 18:16:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juhyung Park X-Patchwork-Id: 10548033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B82E9112B for ; Sat, 28 Jul 2018 17:01:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A10052B23C for ; Sat, 28 Jul 2018 17:01:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F6E22B2FF; Sat, 28 Jul 2018 17:01:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F7BF2B287 for ; Sat, 28 Jul 2018 17:01:14 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 876A8267795; Sat, 28 Jul 2018 19:01:08 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 149CA26774A; Fri, 27 Jul 2018 20:16:53 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by alsa0.perex.cz (Postfix) with ESMTP id 5B3E82675FC for ; Fri, 27 Jul 2018 20:16:51 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id a11-v6so3680733pgw.6 for ; Fri, 27 Jul 2018 11:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=xvRnUhtSXUHORpG7RQsWig/PkSV7M59Uz7nQFeMQ1dU=; b=e/V1ZK5IgYXlN/b8wUZB3Q+GwqiWnjtsEMxhVvI0KS+aR62WmE5E/ZiZ2IFn6tQcbC P2h5qT73WHMYYue2uKCVuyHqaZQbM5TqrBWxe/JjmNDCzw9HDGjNfb9wwSA8z36YVo7f vpWdQ4Mnsxmmb+eqLVrrUJcd9LDbE6mAS+1sftHy6V620NF3cqQisFpHnZpEI2mtB2G2 3DqsUzrRuW7BnaQ4RbAlq78kUnnb/7O1ftp9Kk8dpw1s3BXNMVV9yAuIGhIklNw8lmx3 IhEsQAYMgdEfXLDji/0+9BbUyoRGiX0G/Xg1kkvXbJ+NTek2nE1xDPxF67UMliI9gR0W pOzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xvRnUhtSXUHORpG7RQsWig/PkSV7M59Uz7nQFeMQ1dU=; b=bmzOnUV52SunmnzAPw1z5bo42RPLU6SI1um1OV+zby3KKxyrKZEoTCbdu2TGO6rKXA +hr/GUs7u03/0LYaf5Gu+0F8pxDC7RNV4kxLmF8jgwaoLNLS/kzTSbcIRpQXMukHQSni 9CpDnWFiZmJ9+gEMyHH+bnFwZb9OoOthaBnLwsr2S9WCj9MIxmybQ1J5rKVpEGeNmAJj fW0DgEJU5mggL6cmNNXdwMTH5jB/GU+i2F65/qGa2Zm2oF7q0VUP4/tCCzbYMgHoBCso U5amevpa/RHM5mbv1cBQz+dLVKMZhvuAG3ODt/EyIOAlU7eUulQC7ClRlpaMDfHqw2dh pn+Q== X-Gm-Message-State: AOUpUlHrqJEFmFOW3UbZSChgfvv2ZuJsHsVNxIRPU5XxcT60j9Cf5IZ+ 73cNglbc7TnZ3XUGl4wqr1s= X-Google-Smtp-Source: AAOMgpd9C+6yPh94zQisxw6fWHK5fRIbsjFtjRT9S2D1/i7cKxR5C7hG2GgrSyPGMq6QxfEGltXmdA== X-Received: by 2002:a63:115e:: with SMTP id 30-v6mr7121494pgr.53.1532715410159; Fri, 27 Jul 2018 11:16:50 -0700 (PDT) Received: from localhost.localdomain ([210.123.156.12]) by smtp.gmail.com with ESMTPSA id s27-v6sm7891240pfk.133.2018.07.27.11.16.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 11:16:49 -0700 (PDT) From: Park Ju Hyung To: tiwai@suse.com, alsa-devel@alsa-project.org Date: Sat, 28 Jul 2018 03:16:42 +0900 Message-Id: <20180727181642.7405-1-qkrwngud825@gmail.com> X-Mailer: git-send-email 2.18.0 X-Mailman-Approved-At: Sat, 28 Jul 2018 19:01:04 +0200 Cc: Park Ju Hyung , stable@vger.kernel.org Subject: [alsa-devel] [PATCH 2/2] ALSA: hda - Sleep for 10ms after entering D3 on Conexant codecs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On rare occasions, we are still noticing that the internal speaker spitting out spurious noises even after adding the problematic codec to the list. Adding a 10ms artificial delay before rebooting fixes the issue entirely. Patch for Realtek codecs also adds the same amount of delay after entering D3. Signed-off-by: Park Ju Hyung Cc: --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 909a880f5e01..1a8a2d440fbd 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -226,6 +226,7 @@ static void cx_auto_reboot_notify(struct hda_codec *codec) snd_hda_codec_set_power_to_all(codec, codec->core.afg, AC_PWRST_D3); snd_hda_codec_write(codec, codec->core.afg, 0, AC_VERB_SET_POWER_STATE, AC_PWRST_D3); + msleep(10); } static void cx_auto_free(struct hda_codec *codec)