| Message ID | 20180813223556.16262-1-marcel@ziswiler.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5e4cfadaf5b73a0801b2fa7fb007f98400ebfe6e |
| Headers | show |
| Series | [v2] ASoC: wm9712: fix replace codec to component | expand |
On Tue, Aug 14, 2018 at 12:35:56AM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > "wm9712-codec" got renamed to "wm9712-component", however, this change > never got propagated down to the actual board/platform drivers. E.g. on > Colibri T20 this lead to the following spew upon boot with sound/touch > being broken: > > [ 2.214121] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 2.222137] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 2.344384] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 2.351885] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 2.668339] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 2.675811] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 3.208408] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 3.216312] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 3.235397] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 3.248938] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 14.970443] ALSA device list: > [ 14.996628] No soundcards found. > > This commit finally fixes this again. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
Hi # I know it is very late response Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > "wm9712-codec" got renamed to "wm9712-component", however, this change > never got propagated down to the actual board/platform drivers. E.g. on > Colibri T20 this lead to the following spew upon boot with sound/touch > being broken: > > [ 2.214121] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 2.222137] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 2.344384] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 2.351885] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 2.668339] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 2.675811] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 3.208408] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 3.216312] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 3.235397] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered > [ 3.248938] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517) > ... > [ 14.970443] ALSA device list: > [ 14.996628] No soundcards found. > > This commit finally fixes this again. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- Best regards --- Kuninori Morimoto
diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c index 953d94d50586..ade34c26ad2f 100644 --- a/sound/soc/codecs/wm9712.c +++ b/sound/soc/codecs/wm9712.c @@ -719,7 +719,7 @@ static int wm9712_probe(struct platform_device *pdev) static struct platform_driver wm9712_component_driver = { .driver = { - .name = "wm9712-component", + .name = "wm9712-codec", }, .probe = wm9712_probe,