From patchwork Mon Aug 27 14:15:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10577135 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DCDF71390 for ; Mon, 27 Aug 2018 14:15:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C700529C7B for ; Mon, 27 Aug 2018 14:15:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB0CF29C7E; Mon, 27 Aug 2018 14:15:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEA7729C7B for ; Mon, 27 Aug 2018 14:15:49 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1B24D267849; Mon, 27 Aug 2018 16:15:48 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5E80A26784F; Mon, 27 Aug 2018 16:15:45 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by alsa0.perex.cz (Postfix) with ESMTP id A360E2676C9 for ; Mon, 27 Aug 2018 16:15:42 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id u12-v6so12491086wrr.4 for ; Mon, 27 Aug 2018 07:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=71T6R6aWNapSWbayq2Twd9+vLBT/nvCcltpPmKjGfxQ=; b=jjT2OPmoZyY84/aYyTtlegB8hjwmjfO2+DRyO035Ey6OAo3vJElYR3vySxmhhEKEz2 T1VughSAwIbVsSoXRmZqdjYlbYOWXZg6ciN/zyJny49jQZHeEYe6mHkMk+XZaF41X0WK elFN1CucRWvY8kUuxPhAnLPV9B3ww+2DmQFpqxAQwLCop2AIjl6KqLIeGgWi7+j9vShr 5Rxor6iZrzQaxSsVdcSh2kMT4jZgT4P59QJJ2zrRniHcv1cLv387eAK8e6gsx23Kxz0u 6VoLwFjrmp/OjGphMhhSXILsDc+CRPzzzRIoylKjblOsFgouI0Qwu0vaHLJ4EO+52U2l I37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=71T6R6aWNapSWbayq2Twd9+vLBT/nvCcltpPmKjGfxQ=; b=X+zEd1FneYtqgGzFlclRYQQYE8rZ5mWI0AQEl0RjBHb0v22GneBO/6vXl4X0tsBT3N vZUTW1THfs74g1wnXMnraDWebF+nuhFOpR3V8DJuqWHUGrFDHdIqK76x8ErwteWmfy3q 9gNHobAaZYEAhtqlXyKEOppWGN7Lwtgm8+xZ492O6z+lEZWDUHBIAjuPL6YnWxkWhBsf MwZgBI6tf0Vh1PALbcfF7JDtGfTaEHCTOwWK3lQfebc5BeW9du61lOypaTYPzFX0mJO8 Y5s204dAnIdgc5IvDQQBznxjHCeLou3kkB0V4vrnGMC+0z6UYxIDqJoTs5TNZnaJaWMn jSHw== X-Gm-Message-State: APzg51AVEmWMfUvqn2ckUFrROjpk8FBGVyX8bdSMfhEZQXEE9aAW99Po xbhiWsUX7xhd9yJOLGNM1TwOC7eX+2g= X-Google-Smtp-Source: ANB0VdbpLknyy+BXtXb6C9FECTJ9VQGvccNgkkB/G3hHJWGLHziSJCeoQBvFxx6kYi6S4X8sXp2OJg== X-Received: by 2002:adf:c08c:: with SMTP id d12-v6mr8775637wrf.268.1535379342156; Mon, 27 Aug 2018 07:15:42 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id v133-v6sm14385055wma.36.2018.08.27.07.15.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 07:15:41 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman , Carlo Caione Date: Mon, 27 Aug 2018 16:15:29 +0200 Message-Id: <20180827141529.6497-1-jbrunet@baylibre.com> X-Mailer: git-send-email 2.17.1 Cc: linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet Subject: [alsa-devel] [PATCH] ASoC: meson: axg-fifo: report interrupt request failure X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Return value of request_irq() was irgnored. Fix this and report the failure if any Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-fifo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c index 30262550e37b..0e4f65e654c4 100644 --- a/sound/soc/meson/axg-fifo.c +++ b/sound/soc/meson/axg-fifo.c @@ -203,6 +203,8 @@ static int axg_fifo_pcm_open(struct snd_pcm_substream *ss) ret = request_irq(fifo->irq, axg_fifo_pcm_irq_block, 0, dev_name(dev), ss); + if (ret) + return ret; /* Enable pclk to access registers and clock the fifo ip */ ret = clk_prepare_enable(fifo->pclk);