diff mbox series

[v2,1/3] ASoC: cs4265: SOC_SINGLE register value error fix

Message ID 20180829233802.22032-1-flatmax@flatmax.org (mailing list archive)
State Accepted
Headers show
Series [v2,1/3] ASoC: cs4265: SOC_SINGLE register value error fix | expand

Commit Message

Matt Flax Aug. 29, 2018, 11:38 p.m. UTC 
The cs4265 driver declares the "MMTLR Data Switch" register setting with
a 0 register value rather then the 0x12 register (CS4265_SPDIF_CTL2).
This incorrect value causes alsamixer to fault with the output :
cannot load mixer controls: Input/output error

This patch corrects the register value. alsamixer now runs.

Signed-off-by: Matt Flax <flatmax@flatmax.org>
---

Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Identical to the original v1 patch, already acked and reviewed.
---
 sound/soc/codecs/cs4265.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Charles Keepax Aug. 30, 2018, 9:11 a.m. UTC | #1 
On Thu, Aug 30, 2018 at 09:38:00AM +1000, Matt Flax wrote:
> The cs4265 driver declares the "MMTLR Data Switch" register setting with
> a 0 register value rather then the 0x12 register (CS4265_SPDIF_CTL2).
> This incorrect value causes alsamixer to fault with the output :
> cannot load mixer controls: Input/output error
> 
> This patch corrects the register value. alsamixer now runs.
> 
> Signed-off-by: Matt Flax <flatmax@flatmax.org>
> ---
> 
> Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

These wanted to be above the --- so they are added into the
commit message when the maintainer applies the commit. Probably
not worth resending for it, but keep in mind for future.

Thanks,
Charles
diff mbox series

Patch

diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index 275677de..15b4ae04 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -157,8 +157,7 @@  static const struct snd_kcontrol_new cs4265_snd_controls[] = {
 	SOC_SINGLE("Validity Bit Control Switch", CS4265_SPDIF_CTL2,
 				3, 1, 0),
 	SOC_ENUM("SPDIF Mono/Stereo", spdif_mono_stereo_enum),
-	SOC_SINGLE("MMTLR Data Switch", 0,
-				1, 1, 0),
+	SOC_SINGLE("MMTLR Data Switch", CS4265_SPDIF_CTL2, 0, 1, 0),
 	SOC_ENUM("Mono Channel Select", spdif_mono_select_enum),
 	SND_SOC_BYTES("C Data Buffer", CS4265_C_DATA_BUFF, 24),
 };