diff mbox series

ALSA: oxfw: fix memory leak of private data

Message ID 20180913123118.3640-1-o-takashi@sakamocchi.jp (mailing list archive)
State New, archived
Headers show
Series ALSA: oxfw: fix memory leak of private data | expand

Commit Message

Takashi Sakamoto Sept. 13, 2018, 12:31 p.m. UTC 
Although private data of sound card instance is usually allocated in the
tail of the instance, drivers in ALSA firewire stack allocate the private
data before allocating the instance. In this case, the private data
should be released explicitly at .private_free callback of the instance.

This commit fixes memory leak following to the above design.

Fixes: 6c29230e2a5f ('ALSA: oxfw: delayed registration of sound card')
Cc: <stable@vger.kernel.org> # v4.7+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/oxfw/oxfw.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai Sept. 13, 2018, 1:23 p.m. UTC | #1 
On Thu, 13 Sep 2018 14:31:18 +0200,
Takashi Sakamoto wrote:
> 
> Although private data of sound card instance is usually allocated in the
> tail of the instance, drivers in ALSA firewire stack allocate the private
> data before allocating the instance. In this case, the private data
> should be released explicitly at .private_free callback of the instance.
> 
> This commit fixes memory leak following to the above design.
> 
> Fixes: 6c29230e2a5f ('ALSA: oxfw: delayed registration of sound card')
> Cc: <stable@vger.kernel.org> # v4.7+
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi
diff mbox series

Patch

diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c
index 1e5b2c802635..fd34ef2ac679 100644
--- a/sound/firewire/oxfw/oxfw.c
+++ b/sound/firewire/oxfw/oxfw.c
@@ -130,6 +130,7 @@  static void oxfw_free(struct snd_oxfw *oxfw)
 
 	kfree(oxfw->spec);
 	mutex_destroy(&oxfw->mutex);
+	kfree(oxfw);
 }
 
 /*