| Message ID | 20181215164354.6107-1-grawity@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda: add mute LED support for HP EliteBook 840 G4 | expand |
On Sat, 15 Dec 2018 17:43:54 +0100, Mantas Mikulėnas wrote: > > Tested with 4.19.8. > > (Existing entries for similar models use CXT_FIXUP_HP_DOCK, which might > be a better choice here as well, but that's far beyond my knowledge -- > and I don't have a dock to test it with either.) If CXT_FIXUP_HP_DOCK works for you, I guess it's better to use it. As you guessed, this is likely a better-matching one for EliteBook. Also, the entries are (mostly) sorted in the PCI SSID order. Could you put your new entry in the right place? thanks, Takashi > > Signed-off-by: Mantas Mikulėnas <grawity@gmail.com> > --- > sound/pci/hda/patch_conexant.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 950e02e71766..b04ff8f2cf5c 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -922,6 +922,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = { > SND_PCI_QUIRK(0x1025, 0x054f, "Acer Aspire 4830T", CXT_FIXUP_ASPIRE_DMIC), > SND_PCI_QUIRK(0x103c, 0x8079, "HP EliteBook 840 G3", CXT_FIXUP_HP_DOCK), > SND_PCI_QUIRK(0x103c, 0x807C, "HP EliteBook 820 G3", CXT_FIXUP_HP_DOCK), > + SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_MUTE_LED_GPIO), > SND_PCI_QUIRK(0x103c, 0x80FD, "HP ProBook 640 G2", CXT_FIXUP_HP_DOCK), > SND_PCI_QUIRK(0x103c, 0x83b3, "HP EliteBook 830 G5", CXT_FIXUP_HP_DOCK), > SND_PCI_QUIRK(0x103c, 0x83d3, "HP ProBook 640 G4", CXT_FIXUP_HP_DOCK), > -- > 2.20.0 >
On Sun, Dec 16, 2018 at 11:15 AM Takashi Iwai <tiwai@suse.de> wrote: > > On Sat, 15 Dec 2018 17:43:54 +0100, > Mantas Mikulėnas wrote: > > > > Tested with 4.19.8. > > > > (Existing entries for similar models use CXT_FIXUP_HP_DOCK, which might > > be a better choice here as well, but that's far beyond my knowledge -- > > and I don't have a dock to test it with either.) > > If CXT_FIXUP_HP_DOCK works for you, I guess it's better to use it. > As you guessed, this is likely a better-matching one for EliteBook. Yes, it seems to work fine for me (the LEDs are controlled correctly and I haven't noticed any negative effects). > Also, the entries are (mostly) sorted in the PCI SSID order. Could > you put your new entry in the right place? Will do.
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 950e02e71766..b04ff8f2cf5c 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -922,6 +922,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = { SND_PCI_QUIRK(0x1025, 0x054f, "Acer Aspire 4830T", CXT_FIXUP_ASPIRE_DMIC), SND_PCI_QUIRK(0x103c, 0x8079, "HP EliteBook 840 G3", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x807C, "HP EliteBook 820 G3", CXT_FIXUP_HP_DOCK), + SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x80FD, "HP ProBook 640 G2", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x83b3, "HP EliteBook 830 G5", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x83d3, "HP ProBook 640 G4", CXT_FIXUP_HP_DOCK),
Tested with 4.19.8. (Existing entries for similar models use CXT_FIXUP_HP_DOCK, which might be a better choice here as well, but that's far beyond my knowledge -- and I don't have a dock to test it with either.) Signed-off-by: Mantas Mikulėnas <grawity@gmail.com> --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+)