From patchwork Thu Jan 3 21:59:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yizhuo Zhai X-Patchwork-Id: 10750041 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0DF5B14DE for ; Mon, 7 Jan 2019 07:07:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6E2428712 for ; Mon, 7 Jan 2019 07:07:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D52DB28882; Mon, 7 Jan 2019 07:07:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFE0128712 for ; Mon, 7 Jan 2019 07:07:01 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 7B8FD26789E; Mon, 7 Jan 2019 08:06:59 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 06CED267C04; Thu, 3 Jan 2019 22:59:43 +0100 (CET) Received: from mx6.ucr.edu (mx6.ucr.edu [138.23.62.71]) by alsa0.perex.cz (Postfix) with ESMTP id C18C3267BC7 for ; Thu, 3 Jan 2019 22:59:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1546552781; x=1578088781; h=from:to:cc:subject:date:message-id; bh=/o+PWOz2vh0Ueg52FRsUejU5YUfBK9vRn4AgNH0aLzk=; b=bZFOcKEm0usjZN7ATWoHUSup72ah3TV+JpxKCACdADhZ7O8udOpyA2BH qM8tozaQ9oF6QZg3NzhK58D95TfzU3IISTtrnDTKH3Y0Y6FHEO3yAyIlw DAGSj2mm2fj5Lg/9rSpfqPDOM8iHTmdDSlkS5cWBJraVGgrdzc2+7+QLn RfDUP22mAkZGupuGpixlgAQIRHHcYZySqOmyMi/XCkwDh14Vv1VIGZACs 9wlG0c+hMWBXSx7BUdOCt+YXzQFDPhssWecmDLIIR7+86/XwZKGqDRd6V OvqH6Rzyk+9HVung5aby9YUe1rA7fpBdDQtXyt5PClNLcJHFhMY0a4uO+ Q==; IronPort-PHdr: 9a23:j8Ay7xfRHVAtsz73EEKCfb7elGMj4u6mDksu8pMizoh2WeGdxcuyZB7h7PlgxGXEQZ/co6odzbaO4+a4ASQp2tWoiDg6aptCVhsI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTahYr5+Ngm6oRnMvcQKnIVuLbo8xAHUqXVSYeRWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2QrxeFzQmLns65Nb3uhnZTAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD+v9LlgRgP2hygbNj456GDXhdJ2jKJHuxKquhhzz5fJbI2JKPZye6XQfdYbRWpaRcZRVipBAoyhZIURFuQKIOhYr4jjqFsKsBS1GA2gCe3zxjNNgHL9wK803Pk7EQze3AIuAc8AvnrXotvyL6oeTfy5wbPUwTjZc/9axTHw45XIfBA7pvGMWKp9fsjQyUguFwPFk1KQopHiMjKV1+UNs3KU7+t8We6zhWMqsBxxrSS1xss2lIbGm58Vx0nC+C5kw4g1PcW1RFBnbdOgCpddtCGXO5FoTs8/TGxkojs2x7kCtJKjYSQHyZAqywTBZ/GJc4WE+AzvWeeLLTp6i39ofq+0iQyo/ki60OL8U9G50FNNriVYjNbBrmsN1xnP6sifTft941uh1S6P1w/N7uFEJlg5la/BJJ4gxr48j4ITsUDeEiPvlkX6kaube0E+9uin7OTnZbrmppuCOINulg7+NaEultS+AeQ+LAcOQ3CW9fqg2LDn50H0Q7VHguconqXEv53WP9kXq6q9DgNN14Ys8Re/DzOo0NQCmnkHKUpIeRKGjojpIV7OIez0Aeuxjlm3jTdk2+rGMqf/DZrQM3jPiK3hcqpl605A1AozyshS6IhQCrEaOv3/Q1L+u8LGDhAnNwy52PzoCNFm1owEQG6PGrWZMKTQsVCW+u0vP/OAZIgPuDbyeLAL/fnr2E44i18AeuH9zIkXYXHgRq9OPk6DJ3fgn4FSQi8xogMiQbmy2xW5WjlJaiP3APox X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AfAABrhS5cgMfWVdFjHQEBBQEHBQGBUgcBCwGEAw+MeItaBopXGGyFU4dqgXsBCgEBLIRAgX8iNQgNAQMBAQIBAQIBEwEBCQ0JCCcxgjopgl82UoEVAQUBNVuCRwGBdA0Fm348jBUziFQBB4FMCQEIh2yEQYEPgQeDboR/g1OCQwKBKgEBAYoYhR6QZwEGAgGBW4E5jkkkgyKGWYdqAS2ZVQIEAgQFAgUPIYEmAYIMTSWBbAqBRJB8HjOBB4Zbgk0B X-IPAS-Result: A2AfAABrhS5cgMfWVdFjHQEBBQEHBQGBUgcBCwGEAw+MeItaBopXGGyFU4dqgXsBCgEBLIRAgX8iNQgNAQMBAQIBAQIBEwEBCQ0JCCcxgjopgl82UoEVAQUBNVuCRwGBdA0Fm348jBUziFQBB4FMCQEIh2yEQYEPgQeDboR/g1OCQwKBKgEBAYoYhR6QZwEGAgGBW4E5jkkkgyKGWYdqAS2ZVQIEAgQFAgUPIYEmAYIMTSWBbAqBRJB8HjOBB4Zbgk0B X-IronPort-AV: E=Sophos;i="5.56,436,1539673200"; d="scan'208";a="17510285" Received: from mail-pl1-f199.google.com ([209.85.214.199]) by smtpmx6.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 03 Jan 2019 13:59:38 -0800 Received: by mail-pl1-f199.google.com with SMTP id t10so26227897plo.13 for ; Thu, 03 Jan 2019 13:59:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OLe2NbdQFZsavojLT1j4Z7BY4V9trH7FhUjP2yJHNPw=; b=ml5ENsF73O1eY3tpmDLMF6BMliDZ9GuvYEwPm6JzlO6b3+KGU63Ug9bjNoaHJqdJvq pwU+496kFSzq/FFoG4L4D+mBZRIzEwdl9mJO4kF5BfEAcaoeNVrYyVL80NvZ/JvAVq5O S5msd5w49D70+FSdEDRgW67STAIAYb2HZYHFiFiZeMX0nHX402zlQMR/AUmwcb3zGBlM xVWCvDberJDF6dztIK2Gs4CR2QSpRSXYhAklrkn+jOp13TcdGNGcBpBApePVrUghvrcP k9Sha9Uj/5Woth+U09ToMtpa6Tr2CYROkS2/3f81lYifw7wECXoonO+cI/b7l4PAKVm6 1KWQ== X-Gm-Message-State: AJcUukdSE4/6JR6GBhrGqt1TfwKzacu9aVa6SgZVgWPu0C760Gaueed6 TlZFYpZS1m7wKEg+cKwQhf1ExtFwhNKVtuU70vZQmlFdMXzZ7X2kVBVE4Ac55i3+TNZXBGWzanu zccZJNJiVUg83OEbBaECVPM0c X-Received: by 2002:a17:902:1126:: with SMTP id d35mr45707123pla.1.1546552777548; Thu, 03 Jan 2019 13:59:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN5juxUEdJkBeUTM7honNcfUdRS9AqdNMVwzMPoWrUdgYXHp6IGG3KnIIBzDjhtOHlZRKr2Dvg== X-Received: by 2002:a17:902:1126:: with SMTP id d35mr45707097pla.1.1546552777118; Thu, 03 Jan 2019 13:59:37 -0800 (PST) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id e65sm103581308pfc.74.2019.01.03.13.59.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Jan 2019 13:59:36 -0800 (PST) From: Yizhuo To: Date: Thu, 3 Jan 2019 13:59:12 -0800 Message-Id: <20190103215912.6071-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Mon, 07 Jan 2019 08:06:57 +0100 Cc: csong@cs.ucr.edu, Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , zhiyunq@cs.ucr.edu, Liam Girdwood , Yizhuo , Mark Brown , Bard Liao Subject: [alsa-devel] [PATCH] Variable "val" in function rt274_i2c_probe() could be uninitialized X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Inside function rt274_i2c_probe(), if regmap_read() function returns -EINVAL, then local variable "val" leaves uninitialized but used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo --- sound/soc/codecs/rt274.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c index 8f92e5c4dd9d..cd048df76232 100644 --- a/sound/soc/codecs/rt274.c +++ b/sound/soc/codecs/rt274.c @@ -1128,8 +1128,11 @@ static int rt274_i2c_probe(struct i2c_client *i2c, return ret; } - regmap_read(rt274->regmap, + ret = regmap_read(rt274->regmap, RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val); + if (ret) + return ret; + if (val != RT274_VENDOR_ID) { dev_err(&i2c->dev, "Device with ID register %#x is not rt274\n", val);