From patchwork Fri Jan 25 18:45:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yizhuo Zhai X-Patchwork-Id: 10781917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2DE3691E for ; Fri, 25 Jan 2019 18:56:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1AEDA2E656 for ; Fri, 25 Jan 2019 18:56:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C0AE2F745; Fri, 25 Jan 2019 18:56:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 303402E656 for ; Fri, 25 Jan 2019 18:56:34 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4C8DD2667E7; Fri, 25 Jan 2019 19:56:32 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 003A826680F; Fri, 25 Jan 2019 19:56:29 +0100 (CET) Received: from mx6.ucr.edu (mx6.ucr.edu [138.23.62.71]) by alsa0.perex.cz (Postfix) with ESMTP id 5B37F2666B3 for ; Fri, 25 Jan 2019 19:56:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1548442588; x=1579978588; h=from:to:cc:subject:date:message-id; bh=A6AGaJZxC7CSOYep6As6FAR1JzODsulmW2ZPRkr14ow=; b=pPUgSI1CbNJyIna232VcVYioEUUoPj8WBACMHiDanmxjLHHY1V6jF6EA hdrya+t9O41fa42QXvzMMD8m3UvwbvdufYZ+xKxrVJySH2/30V50b9eB5 vnsxbo6OC6tIsPAmY0Aza2iCFISUZuN9tWHlWQWtGoYHIZLXQW+iWfq2r VtlaXZwF+kdghCWxWu4D1s+HT0vnKWnGreeCX5z2n73qTcPJvlFwL6ad2 gJOw2Bt0bz/XFgHSb3mjLRe3FDVh6phEmh4vM6hRbKPPbAf1DhF1Ffo/U mw6c290UT2w9BaiL/7oHDD+nr14Uq+BNdjcdTvm6VfgRCpjoO+u+MBsjl A==; IronPort-PHdr: 9a23:c9n0RBJztKKZE2Y55tmcpTZWNBhigK39O0sv0rFitYgRIvzxwZ3uMQTl6Ol3ixeRBMOHs6IC07KempujcFRI2YyGvnEGfc4EfD4+ouJSoTYdBtWYA1bwNv/gYn9yNs1DUFh44yPzahANS47xaFLIv3K98yMZFAnhOgppPOT1HZPZg9iq2+yo9JDffwZFiCChbb9uMR67sRjfus4KjIV4N60/0AHJonxGe+RXwWNnO1eelAvi68mz4ZBu7T1et+ou+MBcX6r6eb84TaFDAzQ9L281/szrugLdQgaJ+3ART38ZkhtMAwjC8RH6QpL8uTb0u+ZhxCWXO9D9QKsqUjq+8ahkVB7oiD8GNzEn9mHXltdwh79frB64uhBz35LYbISTOfp7f6PdZsgaRWtHXsZeSidPHJqyZJYBD+oAI+lYq5TyrEYKoRawGQWgAeXiwSJKiHDrx603y+QvHx/b0gIuHNwAt2/ZoMnpOKoITey41rXEwSnFYvhL2Tn98o/IchU5rP6OXLJxcMrRyVQoFwjYiViRqY3kPzOP2eQMr2SX8+RtWPmyi2E7sQF9uCagydoxioTQgI8e11PK9T1hzYorOdG1TFR3bN2kHZdKqS2WKpd6Ttk/T2xsuys20qAKtJ+/cSQQ1pgqyR7SZ+aZf4WJ+B7uVumcLDFlj3x/Yr2/nQy98U24x+35Ucm7zUhFozJektnJqnANzxvT6tWbSvdl/keuxzKP1wfL5+FBO080lK7bJ4c5wr4+i5YfqErDEjLylUj1lqOWeUIk+u+n6+TjfLrqvIOTN4hxig3mM6QunNKwAfggPwQQQ2SW/f6w2b7j8EHjXrlGk+E6nrPEvJ3eJskXvqu5DBVU0oYn5Ra/FTCm0NEAkHgHLVNFeAiIj4n1N13SLv31Fuq/jEi2kDtx2f/JI6DhDo3XLnffiLfhYap960lExQUpydBf/IhbBqgcL/3tRE/+qtjYAwQjPAyw2OboEsxx1psEWWKIAK+WLr/dsUOS6uIoOemMa9xdliz6Lq0U5uzukHhxzU4PfaCohcNMQG2zBLJrL1jPMimkucsIDWpf5ll2d+ftklDXFGELag== X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2C5AABxW0tcf8bSVdFkHAEBAQQBAQcEAQGBUQcBAQsBhAUPjBtfixdQAQEGinxthVeCcoUKgXsBCgEBLIRAgwwiNAkNAQMBAQIBAQIBEwEBCQsLCCcxgjopgl82UoEVAQUBNVuCRwGBdA0FnyY8jBcziGABB4FLCQEIh26EQYEPgQeDboR/g1SCQwKBLAEBAYo5hS2RIgEGAgGBY4FBjnokgzGGcIgFAS2acQIEAgQFAgUPIYElgg5NJYFsCoFEglGOLB4zgQeHWoJNAQ X-IPAS-Result: A2C5AABxW0tcf8bSVdFkHAEBAQQBAQcEAQGBUQcBAQsBhAUPjBtfixdQAQEGinxthVeCcoUKgXsBCgEBLIRAgwwiNAkNAQMBAQIBAQIBEwEBCQsLCCcxgjopgl82UoEVAQUBNVuCRwGBdA0FnyY8jBcziGABB4FLCQEIh26EQYEPgQeDboR/g1SCQwKBLAEBAYo5hS2RIgEGAgGBY4FBjnokgzGGcIgFAS2acQIEAgQFAgUPIYElgg5NJYFsCoFEglGOLB4zgQeHWoJNAQ X-IronPort-AV: E=Sophos;i="5.56,522,1539673200"; d="scan'208";a="23635300" Received: from mail-pf1-f198.google.com ([209.85.210.198]) by smtpmx6.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 25 Jan 2019 10:45:53 -0800 Received: by mail-pf1-f198.google.com with SMTP id y6so1760094pfn.11 for ; Fri, 25 Jan 2019 10:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1QOsUWecV2RDcnzuAuipZco+k6f59evuap0j4RrEzQo=; b=N0+UgYFMnac2ZNoO6gMZAUZEVAIE58aRZyXOnY2ykTrmikqkY2zd1XyZWmGrwIdmR6 oG2H1hKJrRDerw4pLDOZ0gCHbBhfjXRzLtTevZ0SpvQQEfQn1RUjZlAX08GvG8lGYEzD zXH+RATTMMOxbG6MuSfl+U6m1710hxG1S8nzMNR+MwMXoWzcux5loffDkC4KdjZI+NIX WFvp2XdzeEhyNnsYi7JCRuiPrF5sxVFe7AWs2nIZKCAtTPxWFtTr774ao+KS6p6GRP3v rsMW7A0XH3xF/1BMldFWi7uJAfMuckjql2mVuXVZjtdEqriFAF2LCKy4WzLUpvVzfi4i qFzg== X-Gm-Message-State: AJcUukdlxrfEGLR4A1IPAPNIS53sMidAPSFnFvRvlpOf6swo7X003OTn g3Qq0gyZkBYeXHf9Th8CiGLY86YKxubztVu5mSVsdW940r55Rdqu4XPsOrV+t9giG0FkcVWqLx5 ETAeMib8DZT7dSBajRhf0m4qe X-Received: by 2002:a63:be4d:: with SMTP id g13mr11060328pgo.378.1548441953056; Fri, 25 Jan 2019 10:45:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN4eG5mL0LiUw4mtCPBegkwoliucgx9/VQjYjHOdO6c4vwIWIqknx/3RFpXQYUlNPE4aY7waMA== X-Received: by 2002:a63:be4d:: with SMTP id g13mr11060293pgo.378.1548441952615; Fri, 25 Jan 2019 10:45:52 -0800 (PST) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id t3sm26068745pgv.31.2019.01.25.10.45.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 10:45:51 -0800 (PST) From: Yizhuo To: Date: Fri, 25 Jan 2019 10:45:37 -0800 Message-Id: <20190125184537.13419-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.17.1 Cc: csong@cs.ucr.edu, Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , zhiyunq@cs.ucr.edu, Liam Girdwood , Yizhuo , Mark Brown , Bard Liao Subject: [alsa-devel] [PATCH] ASoC: rt5651: Variable "ret" in function rt5651_i2c_probe() could be uninitialized X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP In function rt5651_i2c_probe(), local variable "ret" could be uninitialized if function regmap_read() returns -EINVAL. However, this value is used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo --- sound/soc/codecs/rt5651.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index da60b28ba3df..8d6cbc6b6ff0 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -1734,6 +1734,7 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, struct rt5651_platform_data *pdata = dev_get_platdata(&i2c->dev); struct rt5651_priv *rt5651; int ret; + int err; rt5651 = devm_kzalloc(&i2c->dev, sizeof(*rt5651), GFP_KERNEL); @@ -1755,7 +1756,10 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, return ret; } - regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret); + err = regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret); + if (err) + return err; + if (ret != RT5651_DEVICE_ID_VALUE) { dev_err(&i2c->dev, "Device with ID register %#x is not rt5651\n", ret);