| Message ID | 20190203113741.15203-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | UCM: bytcr/PlatformEnableSeq.conf update some comments | expand |
p.s. Russell, thank you for cleaning up the rt5645 profiles, much appreciated.
On 02/03, Hans de Goede wrote: > Commit f91cc3c7d6b7 ("Update chtrt5645 ucm variants to use > bytcr/PlatformEnableSeq.conf component") updated the > following 2 comments: > > # codec0_out settings (used if SSP2 is connected to aif1) > # modem_out settings (used if SSP0 is connected to aif2) > > Specifically it added the " to aif1" resp. " to aif2" part of the comments. > > This is not correct, AIF1 / AIF2 are something which is present on > Realtek codecs only, and either one can be used indepedent of > SSP0 or SSP2 being used (the comments in the chtrt5645 UCM profile > before this change were wrong / outdated). > > Besides there not being any relationship between SSP0 or SSP2 being > used, bytcr/PlatformEnableSeq.conf is also used with other codecs, > e.g. the ESS8316 codec where this is not applicable at all. > > Therefor this commit removes the " to aif?" part of the comments again > to avoid confusing people reading this in the future. > > Cc: Russell Parker <russell.parker7@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Thanks for updating the comments; I saw that the notes were in the rt5645 sequences and incorrectly assumed that it applied to the platform too. Glad you caught it!
On Sun, 03 Feb 2019 12:37:41 +0100, Hans de Goede wrote: > > Commit f91cc3c7d6b7 ("Update chtrt5645 ucm variants to use > bytcr/PlatformEnableSeq.conf component") updated the > following 2 comments: > > # codec0_out settings (used if SSP2 is connected to aif1) > # modem_out settings (used if SSP0 is connected to aif2) > > Specifically it added the " to aif1" resp. " to aif2" part of the comments. > > This is not correct, AIF1 / AIF2 are something which is present on > Realtek codecs only, and either one can be used indepedent of > SSP0 or SSP2 being used (the comments in the chtrt5645 UCM profile > before this change were wrong / outdated). > > Besides there not being any relationship between SSP0 or SSP2 being > used, bytcr/PlatformEnableSeq.conf is also used with other codecs, > e.g. the ESS8316 codec where this is not applicable at all. > > Therefor this commit removes the " to aif?" part of the comments again > to avoid confusing people reading this in the future. > > Cc: Russell Parker <russell.parker7@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Applied now. Thanks. Takashi
diff --git a/src/conf/ucm/platforms/bytcr/PlatformEnableSeq.conf b/src/conf/ucm/platforms/bytcr/PlatformEnableSeq.conf index 6f5e899c..b5ee2b41 100644 --- a/src/conf/ucm/platforms/bytcr/PlatformEnableSeq.conf +++ b/src/conf/ucm/platforms/bytcr/PlatformEnableSeq.conf @@ -29,7 +29,7 @@ cset "name='pcm0_in Gain 0 Volume' 0" cset "name='pcm1_in Gain 0 Switch' off" cset "name='pcm1_in Gain 0 Volume' 0%" -# codec0_out settings (used if SSP2 is connected to aif1) +# codec0_out settings (used if SSP2 is connected) cset "name='codec_out0 mix 0 codec_in0 Switch' off" cset "name='codec_out0 mix 0 codec_in1 Switch' off" cset "name='codec_out0 mix 0 media_loop1_in Switch' off" @@ -40,7 +40,7 @@ cset "name='codec_out0 mix 0 sprot_loop_in Switch' off" cset "name='codec_out0 Gain 0 Switch' on" cset "name='codec_out0 Gain 0 Volume' 0" -# modem_out settings (used if SSP0 is connected to aif2) +# modem_out settings (used if SSP0 is connected) cset "name='modem_out mix 0 codec_in0 Switch' off" cset "name='modem_out mix 0 codec_in1 Switch' off" cset "name='modem_out mix 0 media_loop1_in Switch' off"
Commit f91cc3c7d6b7 ("Update chtrt5645 ucm variants to use bytcr/PlatformEnableSeq.conf component") updated the following 2 comments: # codec0_out settings (used if SSP2 is connected to aif1) # modem_out settings (used if SSP0 is connected to aif2) Specifically it added the " to aif1" resp. " to aif2" part of the comments. This is not correct, AIF1 / AIF2 are something which is present on Realtek codecs only, and either one can be used indepedent of SSP0 or SSP2 being used (the comments in the chtrt5645 UCM profile before this change were wrong / outdated). Besides there not being any relationship between SSP0 or SSP2 being used, bytcr/PlatformEnableSeq.conf is also used with other codecs, e.g. the ESS8316 codec where this is not applicable at all. Therefor this commit removes the " to aif?" part of the comments again to avoid confusing people reading this in the future. Cc: Russell Parker <russell.parker7@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- src/conf/ucm/platforms/bytcr/PlatformEnableSeq.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)