diff mbox series

[5/5] ALSA: core: Don't allow NULL device for memory allocation

Message ID 20190204134222.9560-6-tiwai@suse.de (mailing list archive)
State New, archived
Headers show
Series ALSA: Fix remaining NULL device with memory allocations | expand

Commit Message

Takashi Iwai Feb. 4, 2019, 1:42 p.m. UTC 
Since we covered all callers with NULL device pointer, let's catch the
remaining calls with NULL and warn explicitly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/memalloc.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
index 59a4adc286ed..eb974235c92b 100644
--- a/sound/core/memalloc.c
+++ b/sound/core/memalloc.c
@@ -182,6 +182,8 @@  int snd_dma_alloc_pages(int type, struct device *device, size_t size,
 		return -ENXIO;
 	if (WARN_ON(!dmab))
 		return -ENXIO;
+	if (WARN_ON(!device))
+		return -EINVAL;
 
 	dmab->dev.type = type;
 	dmab->dev.dev = device;