From patchwork Sat Feb 16 10:09:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 10817449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4CFCB13A4 for ; Mon, 18 Feb 2019 08:10:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3ACAF2A08F for ; Mon, 18 Feb 2019 08:10:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F0B12A0BE; Mon, 18 Feb 2019 08:10:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75A1C2A0D2 for ; Mon, 18 Feb 2019 08:10:09 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 9194126706A; Mon, 18 Feb 2019 09:10:07 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 454C4267418; Mon, 18 Feb 2019 09:10:05 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140051.outbound.protection.outlook.com [40.107.14.51]) by alsa0.perex.cz (Postfix) with ESMTP id 77A0C266FA9 for ; Mon, 18 Feb 2019 09:10:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pzHdtGzR8bmCiGRzaBAmuro2QCHJnbfUXaoHVscWLKw=; b=BcKINYA2h7LmL3Z6Cp48sp8o8f5XKg1c+NiUZtt0nzUNWWyvF71x1fh8JXA8rQ6z+Z1qJPzmnQac5L0C8tjV281b0iYz6XR5Oyh+HZ3gT5V6i8nL05pz5hE6dYLats0nsONMwQsX53zgaxcF60RYX/y3m9krbs4a+CAJ5qeMLHk= Received: from VI1PR0402MB3357.eurprd04.prod.outlook.com (52.134.1.18) by VI1PR0402MB3536.eurprd04.prod.outlook.com (52.134.4.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Sat, 16 Feb 2019 10:09:42 +0000 Received: from VI1PR0402MB3357.eurprd04.prod.outlook.com ([fe80::2d83:eb90:f977:f649]) by VI1PR0402MB3357.eurprd04.prod.outlook.com ([fe80::2d83:eb90:f977:f649%3]) with mapi id 15.20.1622.018; Sat, 16 Feb 2019 10:09:42 +0000 From: Daniel Baluta To: "kuninori.morimoto.gx@renesas.com" , "broonie@kernel.org" , "vicencb@gmail.com" Thread-Topic: [PATCH] ASoC: simple-card: Fix refcount underflow Thread-Index: AQHUxd+7Rfekf4ZvxUOM7mRbKeq/IQ== Date: Sat, 16 Feb 2019 10:09:42 +0000 Message-ID: <20190216100927.10017-1-daniel.baluta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0501CA0019.eurprd05.prod.outlook.com (2603:10a6:800:92::29) To VI1PR0402MB3357.eurprd04.prod.outlook.com (2603:10a6:803:2::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniel.baluta@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.76.156.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac4479d1-2dfc-48a8-287e-08d693f6ddc2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB3536; x-ms-traffictypediagnostic: VI1PR0402MB3536: x-ms-exchange-purlcount: 1 x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; VI1PR0402MB3536; 23:3+xVtMmZ9ZY3rC7Lhf0oEMalhdqizUHQgG3WD?= =?iso-8859-1?q?Et6iK9lMd/Nh84kl+?= =?iso-8859-1?q?2oNF9K5MuM433I5bIGndudlLUNK6BYj61pn0Gg+8YVfgBOByGjfIFTh9rhPy?= =?iso-8859-1?q?R5dDeBxSZJZR1RXILrxb8y8FFzYly9uqbMxcf+pEhIwRAAL3zkEBQg1MzLvS?= =?iso-8859-1?q?fJ18iI+CwxpKDTk6ueLZuWXfN35Fj1WLOkaCWIFHjUqnZcOO7e3zyP2uTM7B?= =?iso-8859-1?q?wSpcjkN4gPAhrEVSFBs3RbVWWHblCVHiqJB52txrQdc94xSSuiJSwLX2U1Wj?= =?iso-8859-1?q?ncPRlwkQ9fEWUHxDTSO/CmGhNgt1WQ8pIQu5IBpUGncaL/JtysGdzYHyhMJc?= =?iso-8859-1?q?lMvl6ixY4wm0QEyXkshm92YeEiotW7JNpZD81n16kaTiLl2TrZbj/OpF1czM?= =?iso-8859-1?q?KgdUAVU33We1+u51kyB1l6RgTnNqRE9FdLkqjVC5fjmaf9vq1M2Xgsr9E920?= =?iso-8859-1?q?mwdwNEWMjlG0sj2lNQRLfjB0rFlmhm6DCt5Fxtiup8BLtKnoPM/mxeUgG8ct?= =?iso-8859-1?q?+TibJAooBMrK+cElBX+cJNBg+uXCFEsTsAaIla7phMVlrScKp/Imhh8pULNv?= =?iso-8859-1?q?AB+hRkVA9k4cSFFE6eb+4X+JoCHdhXqlN9D6NsCjBaYrYCx/FPoOBkXQFcqy?= =?iso-8859-1?q?SvLge14xW9n0aFBLgzDuowM5CydhpLsxPkz6eMizsIt/X12u6L+0kaQGNYmk?= =?iso-8859-1?q?aia7G2narhVnMBs8m2RITCyFapy9KKxzn1/0GBZY9AxeNIAgm+x8ZS7ckdVW?= =?iso-8859-1?q?k0KpY+9SkDFabIQKOr9Tjp82ZxorFuND7WQo9SA1/kvpscy5NChJ9opwoPwV?= =?iso-8859-1?q?iN8GfR+kzXDfvlDyXsyK4d2h5Sn8F+kiKRzJMdrY0pwflAgXpqNszieltLwr?= =?iso-8859-1?q?yXV2T30H2OxN1Edp4DZtIy83auweN8q3ZjWutgbqWHWD6epynp115C4l1Qkn?= =?iso-8859-1?q?8GpVS1vUBaMgwhlRNjGeEeNzGM2mdfq/BSkl8Fuo5qZPjRFaBaj2P0iKgDdW?= =?iso-8859-1?q?6YXxNxDJkXAFLoTorxASLTMAvHg1iEHWzr/HLSV4LRHSebXgQuV3iBl8daED?= =?iso-8859-1?q?4osNXWVXl4ro5QzQtFXboPwG2UFiyIHWUCBFA9aYy6tQi3MFodKR/DpxxhL1?= =?iso-8859-1?q?Zun/FahhlsqvVmDwb63zyE2XySDz3n6XB4Q03H6JMva2GUyHQGPqO5TQKcei?= =?iso-8859-1?q?FBTwakOPXLY7ZkluN+nqZkmaQiSs82hTS5f8pWCPrC0xlOqlFZ7RMtXNdPST?= =?iso-8859-1?q?No7s0BDwH323C5Umzwwx7vdb8Lassay8ZZGWGc/l1PYa7k5g=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0950706AC1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(346002)(39860400002)(396003)(376002)(51234002)(199004)(189003)(106356001)(110136005)(54906003)(316002)(478600001)(66066001)(6512007)(186003)(6306002)(2501003)(102836004)(5660300002)(68736007)(256004)(36756003)(14444005)(1076003)(386003)(6506007)(486006)(2906002)(53936002)(4326008)(26005)(97736004)(305945005)(86362001)(7736002)(6436002)(2201001)(14454004)(44832011)(52116002)(71190400001)(71200400001)(8676002)(50226002)(6486002)(3846002)(476003)(6116002)(25786009)(99286004)(2616005)(8936002)(105586002)(81156014)(81166006)(966005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3536; H:VI1PR0402MB3357.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jvd2YHGU+RKFgtGr+4k4PX6872uLwHbfDhGrp3qu769RxHqRwgOG7S9zNiR6wb4mMDiLvOiyD+KQgJXR6eHCDrfokHTkSyFlDe/2BW0lUztN90I2w7WWzruHfqgdcGbMhv+LjkpnAxvaJJJVNikGTPsNlCvZPYOyNumJFru5BtTL3UEeFfsfdr2DM/J8B7XAss4nd6D8y6iTWC9MLfgWrgFoqyXW4xi/LkmcgJyjlz5tjy461qrrX2gSEhnRyu+ZMcgSw1KKlofSfEhzzmLIa49GrHFESLFWCTOYSdLrMVhI+5O550oREt873igNN2+LJhk3ijhCsMeUGOM2LzFtjXRqcEc4dHDeGPpKxjllPFq25VBVu6wwhhiy4V3g9LC+EyFE5Ds2WfmBoAfUF9cpYYORJdsbzbA9tNbrkUiZ+Pg= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac4479d1-2dfc-48a8-287e-08d693f6ddc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2019 10:09:40.6577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3536 Cc: "alsa-devel@alsa-project.org" , "lgirdwood@gmail.com" , "gregkh@linuxfoundation.org" , "S.j. Wang" , "tiwai@suse.com" , "linux-kernel@vger.kernel.org" , dl-linux-imx , Daniel Baluta Subject: [alsa-devel] [PATCH] ASoC: simple-card: Fix refcount underflow X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP of_get_child_by_name() takes a reference we'll need to drop later so when we substitute in top we need to take a reference as well as just assigning. Without this patch we hit the following error: [ 1.246852] OF: ERROR: Bad of_node_put() on /sound-wm8524 [ 1.262261] Hardware name: NXP i.MX8MQ EVK (DT) [ 1.266807] Workqueue: events deferred_probe_work_func [ 1.271950] Call trace: [ 1.274406] dump_backtrace+0x0/0x158 [ 1.278074] show_stack+0x14/0x20 [ 1.281396] dump_stack+0xa8/0xcc [ 1.284717] of_node_release+0xb0/0xc8 [ 1.288474] kobject_put+0x74/0xf0 [ 1.291879] of_node_put+0x14/0x28 [ 1.295286] __of_get_next_child+0x44/0x70 [ 1.299387] of_get_next_child+0x3c/0x60 [ 1.303315] simple_for_each_link+0x1dc/0x230 [ 1.307676] simple_probe+0x80/0x540 [ 1.311256] platform_drv_probe+0x50/0xa0 This patch is based on an earlier version posted by Kuninori Morimoto and commit message includes explanations from Mark Brown. https://patchwork.kernel.org/patch/10814255/ Reported-by: Vicente Bergas Signed-off-by: Daniel Baluta --- sound/soc/generic/simple-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 08df261024cf..dc18c4492955 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -445,7 +445,7 @@ static int simple_for_each_link(struct simple_priv *priv, /* Check if it has dai-link */ node = of_get_child_by_name(top, PREFIX "dai-link"); if (!node) { - node = top; + node = of_node_get(top); is_top = 1; }