From patchwork Sun Mar 24 23:12:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 10867779 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2ACAB1669 for ; Sun, 24 Mar 2019 23:13:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F25028812 for ; Sun, 24 Mar 2019 23:13:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F30D829092; Sun, 24 Mar 2019 23:13:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EFA6C28812 for ; Sun, 24 Mar 2019 23:13:45 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DB3EF85D; Mon, 25 Mar 2019 00:12:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DB3EF85D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1553469222; bh=7zXnzReqC4S12/H6ueehYsz1ZWoESBtzJFIYLukNbbk=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=tYmQLk+xtKXIgBgUi8TaL2sk1dBdWeE7/jtmoXtbh8/X27XeOJnOzorvYmRUruolS VZi9E6cuEGhi8Q9PxF5AR7Sls6phuWq3Q32gQCllLDuBi/WI4ah/L/cLszbhTugf7z dHqhIxm0CoYaAb4xMLzxpuHiWnb8UgNue5aCDLYc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 56BDEF80C18; Mon, 25 Mar 2019 00:12:52 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id BA532F8961A; Mon, 25 Mar 2019 00:12:50 +0100 (CET) Received: from mta-p5.oit.umn.edu (mta-p5.oit.umn.edu [134.84.196.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8A47EF801DA for ; Mon, 25 Mar 2019 00:12:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8A47EF801DA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="D6ZrUomk" Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 26A47222 for ; Sun, 24 Mar 2019 23:12:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gjn7lr4kFW8K for ; Sun, 24 Mar 2019 18:12:44 -0500 (CDT) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id F331971C for ; Sun, 24 Mar 2019 18:12:43 -0500 (CDT) Received: by mail-io1-f71.google.com with SMTP id c17so6511624iom.21 for ; Sun, 24 Mar 2019 16:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=p81W2EYAA1XZwVj8g477yTnZNACSB+CaBpw4yHrp2XE=; b=D6ZrUomkVE/EDM3m4y0wfKrLUmpb0ID5z7ZLPt/bxRNtGUS85j0gtfgZfcibc97yRP ondZXsdfG/r/N6ZpZZKUCx+3KG82REHC/ms+QqlpZpzti6raRHknMmo2Uh3lDYKhY/Ge OZxvfzGduocjR6t6OKyczTkmPYl4BXZ6MthP2U0KHHp31tzIryiBwWbS2R+ln6DA58Mg DkASmOfMKEITbVcxYEFnYDj4lg8Tznhz8CuoGMs3X8CPehM/d7sCYIKCa8OpoTci8HyV A3zUaqPJgnvUT/gRCOGfsNhlI0eJVP47fcXc+4Oz/obY/qR5VYcOtj+WxJN7dI+ixXIW sXRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=p81W2EYAA1XZwVj8g477yTnZNACSB+CaBpw4yHrp2XE=; b=e1F0mrVfMEMe83/KMzRUpezzvENNHd8Nc0DNFGztCltFsVFPsFtMqceuJddPxdQ5Wu IHq9NkUKI8OWrebzk5jPIUWXWbIz7iZWxZU1WBc5abD677fwZixHhAIEpusBzHZjTUJj y4zYocSSBa9m9FDWyIckw5x0y90ax6C2ftXNWbm2wob8lp1nMIf1isAYwL3yj4THOCx9 e7i3ABsWL/9WWrUw/ggO6220P4VP9rf1IRqk5NIs/UCvBH0IoWjtgS63Xjr23R9Sa5ru 0rlXOP0h+vyMFCALgvHcijpp4Wi1CjcNJ0YSnTFt9D8HutQvKl28mEP10m/x9krY21RK Aj0Q== X-Gm-Message-State: APjAAAUHMVkWZH2b8khdDMrRNMT4WsfnZl5ReS7yx64r1laC6hxcIAVZ ZUiXBAGpn8pjpN15rvrKrjGM7szedGIwVdnao32iXtvqUAtWX1TR/G3Yo5qheRe7gSnIsfZyicV P91+qaxZrT00E5l3dLvwJS0LHIbo= X-Received: by 2002:a24:46cc:: with SMTP id j195mr2255804itb.161.1553469163152; Sun, 24 Mar 2019 16:12:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrUTyermKglrW/G2TO0sGfMkMdypG3iMXcjincVHuMKFn0bCJH1IKu4vEA3SoNhZysE9TVmQ== X-Received: by 2002:a24:46cc:: with SMTP id j195mr2255794itb.161.1553469162949; Sun, 24 Mar 2019 16:12:42 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id i23sm6008964ion.40.2019.03.24.16.12.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 16:12:42 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Date: Sun, 24 Mar 2019 18:12:37 -0500 Message-Id: <20190324231237.2246-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Cc: Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , pakki001@umn.edu, Bard Liao Subject: [alsa-devel] [PATCH] sound: codecs: fix a potential NULL pointer dereference X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP In case devm_kzalloc fails, the patch returns -ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/soc/codecs/rt5663.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/codecs/rt5663.c index da6647015708..909ab99a1995 100644 --- a/sound/soc/codecs/rt5663.c +++ b/sound/soc/codecs/rt5663.c @@ -3480,6 +3480,8 @@ static int rt5663_parse_dp(struct rt5663_priv *rt5663, struct device *dev) table_size = sizeof(struct impedance_mapping_table) * rt5663->pdata.impedance_sensing_num; rt5663->imp_table = devm_kzalloc(dev, table_size, GFP_KERNEL); + if (!rt5663->imp_table) + return -ENOMEM; device_property_read_u32_array(dev, "realtek,impedance_sensing_table", (u32 *)rt5663->imp_table, table_size);