| Message ID | 20190325031740.164364-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,-next] ASoC: simple-card-utils: remove set but not used variable 'dai_name' | expand |
On 3/25/2019 8:47 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': > sound/soc/generic/simple-card-utils.c:164:18: warning: > parameter 'dai_name' set but not used [-Wunused-but-set-parameter] > > It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add > asoc_simple_debug_info()"), so can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> -Mukesh > --- > v2: fix patch title > --- > sound/soc/generic/simple-card-utils.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c > index 4ed68348f939..db1458a19985 100644 > --- a/sound/soc/generic/simple-card-utils.c > +++ b/sound/soc/generic/simple-card-utils.c > @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev, > * see > * soc-core.c :: snd_soc_init_multicodec() > */ > - if (dlc) { > + if (dlc) > dai_of_node = dlc->of_node; > - dai_name = dlc->dai_name; > - } > > /* > * Parse dai->sysclk come from "clocks = <&xxx>" > > >
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index 4ed68348f939..db1458a19985 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev, * see * soc-core.c :: snd_soc_init_multicodec() */ - if (dlc) { + if (dlc) dai_of_node = dlc->of_node; - dai_name = dlc->dai_name; - } /* * Parse dai->sysclk come from "clocks = <&xxx>"
Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': sound/soc/generic/simple-card-utils.c:164:18: warning: parameter 'dai_name' set but not used [-Wunused-but-set-parameter] It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()"), so can be removed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- v2: fix patch title --- sound/soc/generic/simple-card-utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)