diff mbox series

[alsa-plugins] configure: Fix unexpanded ALSA_DATA_DIR

Message ID 20190327114204.26304-1-tiwai@suse.de (mailing list archive)
State New, archived
Headers show
Series [alsa-plugins] configure: Fix unexpanded ALSA_DATA_DIR | expand

Commit Message

Takashi Iwai March 27, 2019, 11:42 a.m. UTC
When no --with-alsadatadir is given, configure scripts takes
$datadir/alsa as the default location, while it's expanded to
$prefix/data/alsa.  Although ALSA_DATA_DIR is set via
AC_DEFINE_UNQUOTED(), this expands only $alsadatadir itself and not
about the $prefix in the content.  For resolving this, we need to do
eval twice.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jaroslav Kysela March 27, 2019, 12:54 p.m. UTC | #1
Dne 27. 03. 19 v 12:42 Takashi Iwai napsal(a):
> When no --with-alsadatadir is given, configure scripts takes
> $datadir/alsa as the default location, while it's expanded to
> $prefix/data/alsa.  Although ALSA_DATA_DIR is set via
> AC_DEFINE_UNQUOTED(), this expands only $alsadatadir itself and not
> about the $prefix in the content.  For resolving this, we need to do
> eval twice.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 1be4a70c803c..5b131e704c2f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -211,7 +211,7 @@ if test -z "$alsadatadir"; then
>      eval dir="$datadir"
>      case "$dir" in
>      /*) ;;
> -    *) dir="$dir"
> +    *) eval dir="$dir"
>      esac
>      alsadatadir="$dir/alsa"
>  fi
> 

Acked-by: Jaroslav Kysela <perex@perex.cz>
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 1be4a70c803c..5b131e704c2f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -211,7 +211,7 @@  if test -z "$alsadatadir"; then
     eval dir="$datadir"
     case "$dir" in
     /*) ;;
-    *) dir="$dir"
+    *) eval dir="$dir"
     esac
     alsadatadir="$dir/alsa"
 fi