From patchwork Tue Apr 2 12:16:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christina Quast X-Patchwork-Id: 10885065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9E67139A for ; Thu, 4 Apr 2019 07:01:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9ACF7286EE for ; Thu, 4 Apr 2019 07:01:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8EC1E285C8; Thu, 4 Apr 2019 07:01:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7F734286EE for ; Thu, 4 Apr 2019 07:01:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3E2AB163F; Thu, 4 Apr 2019 08:42:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3E2AB163F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1554360173; bh=z2sxcapPGxdC9V8qEa9RTaA7f6gfY+7mSfHXn1SpdHw=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=SWLXWXZuBsqmLp+DlRjQ1rbDnVxkwX59YjIcj8ZLSPf0jpNJxw8w6eg/wEX7kOszO mW9L5R1A075JVGoBpPWEZ7hZmnj0Dqx2rc1JZDaINlPGqcFOwadX1rszo7iFPwsnKN dKK67G52PKj8XoSzcI0cYZ0lGbNsUqciUafJzFSo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E183DF8972E; Thu, 4 Apr 2019 08:37:52 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 189F8F89633; Tue, 2 Apr 2019 14:18:30 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 935F9F80715 for ; Tue, 2 Apr 2019 14:18:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 935F9F80715 Received: by mail-wm1-f66.google.com with SMTP id a184so3134540wma.2 for ; Tue, 02 Apr 2019 05:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m0Yhf7dLwYQMZuyIsm9m43WayyXUoQ3uc+OIUwK7dbk=; b=CXauFdqT55R1CI75QTy/DFV7idcMO9iCFbuaLfTBzGcetQX/oQC75bednAh3bGm6Eo 44YTza2VIJT9bdGq5fALtefXEhQDISRkWHE89aSEZGS4/4bWkmLdSIjpQMemmnsheSR8 fJ8Nq0pQMCitU5qGqK/fXv3pqKjp+z8Rieu+ISDq+0LMHBlNoATjVLELAIfnNCSGdGp5 48NhOhuQXrnMTZk/6vrkVYZeJ92B6I3QYI5K5ZxOWpgqegbP6GmAeA6EKqtszMsMaBod O+S97MN39sG/BDP9RUDdhZ2pDCNVbXQXD3IYjEVxIZleufZyoQfbXOMCCBDAsga3nAcu lZEA== X-Gm-Message-State: APjAAAVHLpYmLLIpStEfbGdgdMS7x7vOqUho2HeIbJ5u8JfMi3LrF/Tz NdCfZAN7eZKyx/mAM+qsb2k= X-Google-Smtp-Source: APXvYqyqFujw4wovWdVjUtN+36ti0++nf85+9MErPq7N1QB3eYmj7XzfpK/2lTgmdD4sBFSVBlhPvA== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr3425970wmk.108.1554207506462; Tue, 02 Apr 2019 05:18:26 -0700 (PDT) Received: from localhost ([90.85.130.193]) by smtp.gmail.com with ESMTPSA id 61sm46715482wre.50.2019.04.02.05.18.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 05:18:25 -0700 (PDT) From: Christina Quast To: Date: Tue, 2 Apr 2019 14:16:48 +0200 Message-Id: <20190402121649.26536-1-cquast@hanoverdisplays.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 04 Apr 2019 08:37:43 +0200 Cc: alsa-devel@alsa-project.org, trivial@kernel.org, Jonathan Corbet , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Takashi Iwai , Christina Quast Subject: [alsa-devel] [PATCH] ALSA: doc: my_chip has no element ioport X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP chip->ioport is dereferenced in two places, but the struct is defined as follows: struct mychip { struct snd_card *card; struct pci_dev *pci; unsigned long port; int irq; }; Signed-off-by: Christina Quast --- Documentation/sound/kernel-api/writing-an-alsa-driver.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst index 6b154dbb02cc..132f5eb9b530 100644 --- a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst +++ b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst @@ -324,7 +324,7 @@ to details explained in the following section. strcpy(card->driver, "My Chip"); strcpy(card->shortname, "My Own Chip 123"); sprintf(card->longname, "%s at 0x%lx irq %i", - card->shortname, chip->ioport, chip->irq); + card->shortname, chip->port, chip->irq); /* (5) */ .... /* implemented later */ @@ -437,7 +437,7 @@ Since each component can be properly freed, the single strcpy(card->driver, "My Chip"); strcpy(card->shortname, "My Own Chip 123"); sprintf(card->longname, "%s at 0x%lx irq %i", - card->shortname, chip->ioport, chip->irq); + card->shortname, chip->port, chip->irq); The driver field holds the minimal ID string of the chip. This is used by alsa-lib's configurator, so keep it simple but unique. Even the