From patchwork Sun Apr 14 21:02:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alyssa Rosenzweig X-Patchwork-Id: 10903757 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A44317E0 for ; Tue, 16 Apr 2019 18:27:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50D672853A for ; Tue, 16 Apr 2019 18:27:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 44DD6289C4; Tue, 16 Apr 2019 18:27:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 556C42853A for ; Tue, 16 Apr 2019 18:27:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 90A6D88A; Tue, 16 Apr 2019 20:26:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 90A6D88A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1555439258; bh=Dai29iWu+KERw83D7IKRtdH4V72V2mIcM80IDnKW9IQ=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Lp1M+MPe5kjYmks7yNzbOXA6m24aruI0YuBNIpQcswfk3ue8F1jR+4uiFGIj38Qz8 tc5M3W4MmqQodamGmce8Mv2bK8Lh50yeRL99JM5t8N2seQUx+NqE9DdFwzpy0knV1L 7Ij13ngSliu94MJn15A5Shw9cgAvxGkhUDwH1lGU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C17CFF89616; Tue, 16 Apr 2019 20:23:51 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 455A7F896E4; Sun, 14 Apr 2019 23:02:23 +0200 (CEST) Received: from rosenzweig.io (rosenzweig.io [107.170.207.86]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7B64BF896E2 for ; Sun, 14 Apr 2019 23:02:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7B64BF896E2 From: Alyssa Rosenzweig To: linux-rockchip@lists.infradead.org Date: Sun, 14 Apr 2019 14:02:12 -0700 Message-Id: <20190414210212.2144-1-alyssa@rosenzweig.io> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 16 Apr 2019 20:23:44 +0200 Cc: alsa-devel@alsa-project.org, Heiko Stuebner , Takashi Iwai , Liam Girdwood , Mark Brown , linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig Subject: [alsa-devel] [PATCH] ASoC: rockchip: Select DMA_PL330 by RK3399 audio X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP Without the appropriate DMA controller selected, the RK3399 audio drivers compile but fail immediately. Accordingly, selecting the RK3399 audio without the corresponding PL330 controller is an invalid configuration. Prevent errors (otherwise forcing the driver to unload at runtime) by an appropriate `select` directive in the Kconfig. Signed-off-by: Alyssa Rosenzweig Cc: Heiko Stuebner Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/soc/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 957046ac6c8c..fa3cab461a60 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -73,6 +73,7 @@ config SND_SOC_RK3399_GRU_SOUND select SND_SOC_RT5514_SPI select SND_SOC_HDMI_CODEC select SND_SOC_DMIC + select PL330_DMA help Say Y or M here if you want to add support multiple codecs for SoC audio on Rockchip RK3399 GRU boards.