From patchwork Sat Apr 27 17:54:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ladislav Michl X-Patchwork-Id: 10920457 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4850315E9 for ; Sat, 27 Apr 2019 18:21:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32CCF289BE for ; Sat, 27 Apr 2019 18:21:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26A43289D4; Sat, 27 Apr 2019 18:21:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 18E2D289BE for ; Sat, 27 Apr 2019 18:21:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4ED951641; Sat, 27 Apr 2019 20:21:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4ED951641 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1556389311; bh=xpzgvLmuxkisPTKijJ5U0KMBFqs97vAQIgEOnPPEW08=; h=Date:From:To:In-Reply-To:Cc:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=LeZlk8JPqG4NLasPeRNJ4EZoQaJiP/OLZFhlWiHZz2LNZWjf5HzljNFnaWauk6EjS Hv7FgIqGsvywLqjp7cA+d0Y5fudeBLGbWGGlPNfT7pfl0JHWBnzvrCmqUhnUCaR9XN KAsv/MnLFLI1TIlggHT1Qln5BszJJCrd/49KKEIw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8AED2F898A1; Sat, 27 Apr 2019 19:55:42 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9468EF8973E; Sat, 27 Apr 2019 19:54:47 +0200 (CEST) Received: from cvs.linux-mips.org (eddie.linux-mips.org [148.251.95.138]) by alsa1.perex.cz (Postfix) with ESMTP id 88667F897B6 for ; Sat, 27 Apr 2019 19:54:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 88667F897B6 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23991216AbfD0Rymfm5J6 (ORCPT ); Sat, 27 Apr 2019 19:54:42 +0200 Date: Sat, 27 Apr 2019 19:54:41 +0200 From: Ladislav Michl To: alsa-devel@alsa-project.org Message-ID: <20190427175441.GA21587@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Petr Nosek Subject: [alsa-devel] [PATCH] ALSA: hda/realtek: Enable internal speaker of ASUS UX362FA with ALC294 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP The ASUS UX362FA with ALC294 cannot detect the outputs through the internal speaker until ALC294_FIXUP_ASUS_SPK quirk applied. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=203443 Suggested-by: Petr Nosek Signed-off-by: Ladislav Michl --- Hi Petr, I tried to verify information in your patch, but all links you provided are unpleasant to read and you also didn't provide bootlog, so I had to trust you that your machine comes with ALC294... Also, does it fix internal speaker only or also headphones? We need to get commit log right. Once verified, let's send v2 of this patch with your Tested-by tag and posibly Cc: stable. Thank you. sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 070749b50eff..490b42e3e3dc 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6896,6 +6896,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12f0, "ASUS X541UV", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), + SND_PCI_QUIRK(0x1043, 0x13e1, "ASUS UX362FA", ALC294_FIXUP_ASUS_SPK), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),