| Message ID | 20190508063313.18099-1-flatmax@flatmax.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f3df05c805983427319eddc2411a2105ee1757cf |
| Headers | show |
| Series | ASoC : cs4265 : readable register too low | expand |
On Wed, May 08, 2019 at 04:33:13PM +1000, Matt Flax wrote: > The cs4265_readable_register function stopped short of the maximum > register. > > An example bug is taken from : > https://github.com/Audio-Injector/Ultra/issues/25 > > Where alsactl store fails with : > Cannot read control '2,0,0,C Data Buffer,0': Input/output error > > This patch fixes the bug by setting the cs4265 to have readable > registers up to the maximum hardware register CS4265_MAX_REGISTER. > > Signed-off-by: Matt Flax <flatmax@flatmax.org> > --- Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c index ab27d2b94d02..c0190ec59e74 100644 --- a/sound/soc/codecs/cs4265.c +++ b/sound/soc/codecs/cs4265.c @@ -60,7 +60,7 @@ static const struct reg_default cs4265_reg_defaults[] = { static bool cs4265_readable_register(struct device *dev, unsigned int reg) { switch (reg) { - case CS4265_CHIP_ID ... CS4265_SPDIF_CTL2: + case CS4265_CHIP_ID ... CS4265_MAX_REGISTER: return true; default: return false;
The cs4265_readable_register function stopped short of the maximum register. An example bug is taken from : https://github.com/Audio-Injector/Ultra/issues/25 Where alsactl store fails with : Cannot read control '2,0,0,C Data Buffer,0': Input/output error This patch fixes the bug by setting the cs4265 to have readable registers up to the maximum hardware register CS4265_MAX_REGISTER. Signed-off-by: Matt Flax <flatmax@flatmax.org> --- sound/soc/codecs/cs4265.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)