Message ID | 20190704191026.GA20732@hari-Inspiron-1545 (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag | expand |
On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote: > Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq > handler finished". > > fixes below issue reported by coccicheck > > sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > sound/soc/codecs/wcd9335.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > index 85737fe..7ab9bf6f 100644 > --- a/sound/soc/codecs/wcd9335.c > +++ b/sound/soc/codecs/wcd9335.c > @@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = { > static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) > { > int irq, ret, i; > + unsigned long irqflags; > + > + irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT; Why does this change trigger adding a variable? > for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) { > irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq); > @@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) > > ret = devm_request_threaded_irq(wcd->dev, irq, NULL, > wcd9335_irqs[i].handler, > - IRQF_TRIGGER_RISING, > + irqflags, > wcd9335_irqs[i].name, wcd); > if (ret) { > dev_err(wcd->dev, "Failed to request %s\n", > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Fri, Jul 05, 2019 at 10:10:06PM +0200, Ladislav Michl wrote: > On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote: > > Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq > > handler finished". > > > > fixes below issue reported by coccicheck > > > > sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no > > primary handler requested without IRQF_ONESHOT > > > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > --- > > sound/soc/codecs/wcd9335.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > > index 85737fe..7ab9bf6f 100644 > > --- a/sound/soc/codecs/wcd9335.c > > +++ b/sound/soc/codecs/wcd9335.c > > @@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = { > > static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) > > { > > int irq, ret, i; > > + unsigned long irqflags; > > + > > + irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT; > > Why does this change trigger adding a variable? Yes variable is not required. Will resend the patch without variable. > > > for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) { > > irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq); > > @@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) > > > > ret = devm_request_threaded_irq(wcd->dev, irq, NULL, > > wcd9335_irqs[i].handler, > > - IRQF_TRIGGER_RISING, > > + irqflags, > > wcd9335_irqs[i].name, wcd); > > if (ret) { > > dev_err(wcd->dev, "Failed to request %s\n", > > -- > > 2.7.4 > > > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel@alsa-project.org > > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 85737fe..7ab9bf6f 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = { static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) { int irq, ret, i; + unsigned long irqflags; + + irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT; for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) { irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq); @@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) ret = devm_request_threaded_irq(wcd->dev, irq, NULL, wcd9335_irqs[i].handler, - IRQF_TRIGGER_RISING, + irqflags, wcd9335_irqs[i].name, wcd); if (ret) { dev_err(wcd->dev, "Failed to request %s\n",
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq handler finished". fixes below issue reported by coccicheck sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> --- sound/soc/codecs/wcd9335.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)