diff mbox series

[v2] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag

Message ID 20190710021627.GA13396@hari-Inspiron-1545 (mailing list archive)
State Accepted
Commit af62a3c8a872631e63833e2a99a8f43f81532fae
Headers show
Series [v2] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag | expand

Commit Message

Hariprasad Kelam July 10, 2019, 2:16 a.m. UTC 
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
handler finished".

fixes below issue reported by coccicheck

sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
v1 : add IRQF_ONESHOT and introduce irqflags variable 
v2 : remove irqflags variable

 sound/soc/codecs/wcd9335.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 1bbbe42..9566027 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -4062,7 +4062,8 @@  static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
 
 		ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
 						wcd9335_irqs[i].handler,
-						IRQF_TRIGGER_RISING,
+						IRQF_TRIGGER_RISING |
+						IRQF_ONESHOT,
 						wcd9335_irqs[i].name, wcd);
 		if (ret) {
 			dev_err(wcd->dev, "Failed to request %s\n",