| Message ID | 20190725234032.21152-20-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: updates for 5.4 | expand |
On 25-07-19, 18:40, Pierre-Louis Bossart wrote: > update comments to provide better understanding of enumeration flows. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/soundwire/bus.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index bca378806d00..2354675ef104 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -483,7 +483,8 @@ static int sdw_assign_device_num(struct sdw_slave *slave) > > ret = sdw_write(slave, SDW_SCP_DEVNUMBER, dev_num); > if (ret < 0) { > - dev_err(&slave->dev, "Program device_num failed: %d\n", ret); > + dev_err(&slave->dev, "Program device_num %d failed: %d\n", > + dev_num, ret); > return ret; > } > > @@ -540,6 +541,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) > do { > ret = sdw_transfer(bus, &msg); > if (ret == -ENODATA) { /* end of device id reads */ > + dev_dbg(bus->dev, "No more devices to enumerate\n"); > ret = 0; > break; > } > @@ -982,6 +984,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus, > int i, ret = 0; > > if (status[0] == SDW_SLAVE_ATTACHED) { > + dev_err(bus->dev, "Slave attached, programming device number\n"); This should be debug level
On 8/2/19 12:00 PM, Vinod Koul wrote: > On 25-07-19, 18:40, Pierre-Louis Bossart wrote: >> update comments to provide better understanding of enumeration flows. >> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> --- >> drivers/soundwire/bus.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c >> index bca378806d00..2354675ef104 100644 >> --- a/drivers/soundwire/bus.c >> +++ b/drivers/soundwire/bus.c >> @@ -483,7 +483,8 @@ static int sdw_assign_device_num(struct sdw_slave *slave) >> >> ret = sdw_write(slave, SDW_SCP_DEVNUMBER, dev_num); >> if (ret < 0) { >> - dev_err(&slave->dev, "Program device_num failed: %d\n", ret); >> + dev_err(&slave->dev, "Program device_num %d failed: %d\n", >> + dev_num, ret); >> return ret; >> } >> >> @@ -540,6 +541,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) >> do { >> ret = sdw_transfer(bus, &msg); >> if (ret == -ENODATA) { /* end of device id reads */ >> + dev_dbg(bus->dev, "No more devices to enumerate\n"); >> ret = 0; >> break; >> } >> @@ -982,6 +984,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus, >> int i, ret = 0; >> >> if (status[0] == SDW_SLAVE_ATTACHED) { >> + dev_err(bus->dev, "Slave attached, programming device number\n"); > > This should be debug level yes, good catch, will fix.
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index bca378806d00..2354675ef104 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -483,7 +483,8 @@ static int sdw_assign_device_num(struct sdw_slave *slave) ret = sdw_write(slave, SDW_SCP_DEVNUMBER, dev_num); if (ret < 0) { - dev_err(&slave->dev, "Program device_num failed: %d\n", ret); + dev_err(&slave->dev, "Program device_num %d failed: %d\n", + dev_num, ret); return ret; } @@ -540,6 +541,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) do { ret = sdw_transfer(bus, &msg); if (ret == -ENODATA) { /* end of device id reads */ + dev_dbg(bus->dev, "No more devices to enumerate\n"); ret = 0; break; } @@ -982,6 +984,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus, int i, ret = 0; if (status[0] == SDW_SLAVE_ATTACHED) { + dev_err(bus->dev, "Slave attached, programming device number\n"); ret = sdw_program_device_num(bus); if (ret) dev_err(bus->dev, "Slave attach failed: %d\n", ret);
update comments to provide better understanding of enumeration flows. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- drivers/soundwire/bus.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)