From patchwork Tue Sep 10 13:51:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 11139649 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1327C76 for ; Tue, 10 Sep 2019 13:53:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B35C208E4 for ; Tue, 10 Sep 2019 13:53:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Yb0aEMAQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="kaAGGE+7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ldqj6RBr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B35C208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A326F166F; Tue, 10 Sep 2019 15:53:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A326F166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568123633; bh=nD6NPn6J0OqIgQVXvHysQVzUVTAdMGI3uCWHVmGdAgU=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Yb0aEMAQo6nGj0OOzf/77eNErNAA9AK8PEVZgIyBNMbhMzl4j4UcjmDZaRou37b4E H1/k3L1lYMlZMVOXnv1rOYF/sQIklCVHv2yZ26wzb/sbxu+ztmVR/CsAi8Z0NjWYap 3FMtvbdTg1R1V+lwZMYiERlkucMkYjR/xRUZ4Z/Q= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 985F6F80444; Tue, 10 Sep 2019 15:52:09 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79B8EF8036F; Tue, 10 Sep 2019 15:52:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B8501F800C9 for ; Tue, 10 Sep 2019 15:52:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B8501F800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="kaAGGE+7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ldqj6RBr" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6EA5F54A; Tue, 10 Sep 2019 09:51:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 10 Sep 2019 09:51:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=moGB0nJAJd72r zqXrDEkU8H1iO7t69avZoCbt5iv/4o=; b=kaAGGE+7nrkw33MzKo69TsdZsUJee YMxBUKB7R/XC7HVjm4CyYXiPPhVp2J+mOi+mMTXmC5i27PuzD9YUh7sVnowY7kfL EumHQge+65rsXvF1TQG0ZYmvDyDOEBR9I62uWPPWOb55dlkLGPgPn9vTuqmTHz3f nz/SU8TiBfQLuxhdVKTZmQ0ey4Ygf8hQM1OVH4Zhe9bVgS5igVHPG7tAqth7tMxT CjVjqtlEz9V0m4kA4fQxZLXKUFRJ4ikmwy2mC7uTdM9SD1j7z/roHer4Ogc/XCEM wUW4hR81HljevxgkCm0ZmE9Jq8pjrymmuptZcyT5fO1swZkuc+/JEY1qA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=moGB0nJAJd72rzqXrDEkU8H1iO7t69avZoCbt5iv/4o=; b=ldqj6RBr b/5BHAz80rbgIrP696s1IEgFp6bv+zudfu/0b63KFbXq2Ybif3LYxV1gayq3G4fy ORR0btzVWzEuShu8lhqpnouxoUeuGJ7cA3piOeg0e7EepwmD7L5B/5JJVZcwWmA6 afLr2KcK/sOvSKPY+9f95628kM6vNzvqHuj/kyDmJMxWrAnE8cBZegc7lXTdxvNG oxuL+r7dY/Iaxu0mVWQUqzQEN5LqLZBueF6gFbjRve39jW9cAMG+8UXrG9/FInvk kkS0z237WLgPkEdesHuGUp25JismSoS6FMtkvS4uXWunY3zfZ3sTiBS8BITuyAGH djdGSEiqQS43qg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtddtgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucfkphepudegrdefrdejhedrudekudenuc frrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhi rdhjphenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from workstation.flets-east.jp (ae075181.dynamic.ppp.asahi-net.or.jp [14.3.75.181]) by mail.messagingengine.com (Postfix) with ESMTPA id 7D49FD6005A; Tue, 10 Sep 2019 09:51:57 -0400 (EDT) From: Takashi Sakamoto To: clemens@ladisch.de, tiwai@suse.de Date: Tue, 10 Sep 2019 22:51:51 +0900 Message-Id: <20190910135152.29800-2-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190910135152.29800-1-o-takashi@sakamocchi.jp> References: <20190910135152.29800-1-o-takashi@sakamocchi.jp> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: [alsa-devel] [PATCH 1/2] ALSA: firewire-tascam: handle error code when getting current source of clock X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The return value of snd_tscm_stream_get_clock() is ignored. This commit checks the value and handle error. Fixes: e453df44f0d6 ("ALSA: firewire-tascam: add PCM functionality") Cc: # v4.4+ Signed-off-by: Takashi Sakamoto --- sound/firewire/tascam/tascam-pcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/firewire/tascam/tascam-pcm.c b/sound/firewire/tascam/tascam-pcm.c index b5ced5415e40..2377732caa52 100644 --- a/sound/firewire/tascam/tascam-pcm.c +++ b/sound/firewire/tascam/tascam-pcm.c @@ -56,6 +56,9 @@ static int pcm_open(struct snd_pcm_substream *substream) goto err_locked; err = snd_tscm_stream_get_clock(tscm, &clock); + if (err < 0) + goto err_locked; + if (clock != SND_TSCM_CLOCK_INTERNAL || amdtp_stream_pcm_running(&tscm->rx_stream) || amdtp_stream_pcm_running(&tscm->tx_stream)) {