diff mbox series

[2/9] Revert "ASoC: SOF: Force polling mode on CFL and CNL"

Message ID 20191008164443.1358-3-pierre-louis.bossart@linux.intel.com (mailing list archive)
State Accepted
Commit 902fd492d5ea2c02666ddadc1da977ca94e6b52c
Headers show
Series ASoC: SOF updates for Intel/i.MX | expand

Commit Message

Pierre-Louis Bossart Oct. 8, 2019, 4:44 p.m. UTC 
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>

This reverts commit 64ca9d9fcb3e3c86b1417e3d17a90b43dd660f81.

The workaround is no longer needed after configuring HDAC
bus with sync_write=1.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/intel/hda.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Mark Brown Oct. 10, 2019, 2:08 p.m. UTC | #1 
On Tue, Oct 08, 2019 at 11:44:36AM -0500, Pierre-Louis Bossart wrote:
> From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> 
> This reverts commit 64ca9d9fcb3e3c86b1417e3d17a90b43dd660f81.

Please use normal subject lines even for reverts - it makes
things esier to spot.
Pierre-Louis Bossart Oct. 10, 2019, 3:41 p.m. UTC | #2 
>> From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>>
>> This reverts commit 64ca9d9fcb3e3c86b1417e3d17a90b43dd660f81.
> 
> Please use normal subject lines even for reverts - it makes
> things esier to spot.

ok, will do next time. I thought the opposite was recommended - using 
the default git style.
diff mbox series

Patch

diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
index 5a5163eef2ef..103f4273c4d3 100644
--- a/sound/soc/sof/intel/hda.c
+++ b/sound/soc/sof/intel/hda.c
@@ -32,9 +32,6 @@ 
 /* platform specific devices */
 #include "shim.h"
 
-#define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348)
-#define IS_CNL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x9dc8)
-
 #define EXCEPT_MAX_HDR_SIZE	0x400
 
 /*
@@ -262,10 +259,6 @@  static int hda_init(struct snd_sof_dev *sdev)
 	/* HDA bus init */
 	sof_hda_bus_init(bus, &pci->dev);
 
-	/* Workaround for a communication error on CFL (bko#199007) and CNL */
-	if (IS_CFL(pci) || IS_CNL(pci))
-		bus->polling_mode = 1;
-
 	bus->use_posbuf = 1;
 	bus->bdl_pos_adj = 0;
 	bus->sync_write = 1;