| Message ID | 20191014091308.23688-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9899a7a869935c4c93247b290ac7a70e0deab202 |
| Headers | show |
| Series | [-next] ASoC: SOF: Fix randbuild error | expand |
On 10/14/19 4:13 AM, YueHaibing wrote: > When LEDS_TRIGGER_AUDIO is m and SND_SOC_SOF is y, > > sound/soc/sof/control.o: In function `snd_sof_switch_put': > control.c:(.text+0x587): undefined reference to `ledtrig_audio_set' > control.c:(.text+0x593): undefined reference to `ledtrig_audio_set' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 5d43001ae436 ("ASoC: SOF: acpi led support for switch controls") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks for the fix. Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > sound/soc/sof/control.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/sof/control.c b/sound/soc/sof/control.c > index 41551e8..2c4abd4 100644 > --- a/sound/soc/sof/control.c > +++ b/sound/soc/sof/control.c > @@ -36,10 +36,12 @@ static void update_mute_led(struct snd_sof_control *scontrol, > > scontrol->led_ctl.led_value = temp; > > +#if IS_REACHABLE(CONFIG_LEDS_TRIGGER_AUDIO) > if (!scontrol->led_ctl.direction) > ledtrig_audio_set(LED_AUDIO_MUTE, temp ? LED_OFF : LED_ON); > else > ledtrig_audio_set(LED_AUDIO_MICMUTE, temp ? LED_OFF : LED_ON); > +#endif > } > > static inline u32 mixer_to_ipc(unsigned int value, u32 *volume_map, int size) >
diff --git a/sound/soc/sof/control.c b/sound/soc/sof/control.c index 41551e8..2c4abd4 100644 --- a/sound/soc/sof/control.c +++ b/sound/soc/sof/control.c @@ -36,10 +36,12 @@ static void update_mute_led(struct snd_sof_control *scontrol, scontrol->led_ctl.led_value = temp; +#if IS_REACHABLE(CONFIG_LEDS_TRIGGER_AUDIO) if (!scontrol->led_ctl.direction) ledtrig_audio_set(LED_AUDIO_MUTE, temp ? LED_OFF : LED_ON); else ledtrig_audio_set(LED_AUDIO_MICMUTE, temp ? LED_OFF : LED_ON); +#endif } static inline u32 mixer_to_ipc(unsigned int value, u32 *volume_map, int size)
When LEDS_TRIGGER_AUDIO is m and SND_SOC_SOF is y, sound/soc/sof/control.o: In function `snd_sof_switch_put': control.c:(.text+0x587): undefined reference to `ledtrig_audio_set' control.c:(.text+0x593): undefined reference to `ledtrig_audio_set' Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 5d43001ae436 ("ASoC: SOF: acpi led support for switch controls") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- sound/soc/sof/control.c | 2 ++ 1 file changed, 2 insertions(+)