| Message ID | 20200106113903.279394-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 869bced7a055665e3ddb1ba671a441ce6f997bf1 |
| Headers | show |
| Series | ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk | expand |
On 1/6/20 5:39 AM, Hans de Goede wrote: > When a quirk for the Irbis NB41 netbook was added, to override the defaults > for this device, I forgot to add/keep the BYT_CHT_ES8316_SSP0 part of the > defaults, completely breaking audio on this netbook. > > This commit adds the BYT_CHT_ES8316_SSP0 flag to the Irbis NB41 netbook > quirk, making audio work again. > > Cc: stable@vger.kernel.org > Cc: russianneuromancer@ya.ru > Fixes: aa2ba991c420 ("ASoC: Intel: bytcht_es8316: Add quirk for Irbis NB41 netbook") > Reported-and-tested-by: russianneuromancer@ya.ru > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > sound/soc/intel/boards/bytcht_es8316.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c > index 46612331f5ea..54e97455d7f6 100644 > --- a/sound/soc/intel/boards/bytcht_es8316.c > +++ b/sound/soc/intel/boards/bytcht_es8316.c > @@ -442,7 +442,8 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = { > DMI_MATCH(DMI_SYS_VENDOR, "IRBIS"), > DMI_MATCH(DMI_PRODUCT_NAME, "NB41"), > }, > - .driver_data = (void *)(BYT_CHT_ES8316_INTMIC_IN2_MAP > + .driver_data = (void *)(BYT_CHT_ES8316_SSP0 > + | BYT_CHT_ES8316_INTMIC_IN2_MAP > | BYT_CHT_ES8316_JD_INVERTED), > }, > { /* Teclast X98 Plus II */ >
diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c index 46612331f5ea..54e97455d7f6 100644 --- a/sound/soc/intel/boards/bytcht_es8316.c +++ b/sound/soc/intel/boards/bytcht_es8316.c @@ -442,7 +442,8 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = { DMI_MATCH(DMI_SYS_VENDOR, "IRBIS"), DMI_MATCH(DMI_PRODUCT_NAME, "NB41"), }, - .driver_data = (void *)(BYT_CHT_ES8316_INTMIC_IN2_MAP + .driver_data = (void *)(BYT_CHT_ES8316_SSP0 + | BYT_CHT_ES8316_INTMIC_IN2_MAP | BYT_CHT_ES8316_JD_INVERTED), }, { /* Teclast X98 Plus II */
When a quirk for the Irbis NB41 netbook was added, to override the defaults for this device, I forgot to add/keep the BYT_CHT_ES8316_SSP0 part of the defaults, completely breaking audio on this netbook. This commit adds the BYT_CHT_ES8316_SSP0 flag to the Irbis NB41 netbook quirk, making audio work again. Cc: stable@vger.kernel.org Cc: russianneuromancer@ya.ru Fixes: aa2ba991c420 ("ASoC: Intel: bytcht_es8316: Add quirk for Irbis NB41 netbook") Reported-and-tested-by: russianneuromancer@ya.ru Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- sound/soc/intel/boards/bytcht_es8316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)