diff mbox series

ALSA: usb-audio: unlock on error in probe

Message ID 20200115174604.rhanfgy4j3uc65cx@kili.mountain (mailing list archive)
State New, archived
Headers show
Series ALSA: usb-audio: unlock on error in probe | expand

Commit Message

Dan Carpenter Jan. 15, 2020, 5:46 p.m. UTC 
We need to unlock before we returning on this error path.

Fixes: 73ac9f5e5b43 ("ALSA: usb-audio: Add boot quirk for MOTU M Series")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/usb/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai Jan. 15, 2020, 7:26 p.m. UTC | #1 
On Wed, 15 Jan 2020 18:46:04 +0100,
Dan Carpenter wrote:
> 
> We need to unlock before we returning on this error path.
> 
> Fixes: 73ac9f5e5b43 ("ALSA: usb-audio: Add boot quirk for MOTU M Series")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/usb/card.c b/sound/usb/card.c
index 2f582ac7cf78..827fb0bc8b56 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -602,7 +602,7 @@  static int usb_audio_probe(struct usb_interface *intf,
 	if (! chip) {
 		err = snd_usb_apply_boot_quirk_once(dev, intf, quirk, id);
 		if (err < 0)
-			return err;
+			goto __error;
 
 		/* it's a fresh one.
 		 * now look for an empty slot and create a new card instance