| Message ID | 20200204111241.6927-1-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 42b716359beca10684195fd6e93a74ecd8ca8003 |
| Headers | show |
| Series | [v2] ASoC: wcd934x: Add missing COMMON_CLK dependency | expand |
Hi Srinivas, On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > Looks like some platforms are not yet using COMMON CLK. > > PowerPC allyesconfig failed with below error in next > > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): > undefined reference to `of_clk_src_simple_get' > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe': > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): > undefined reference to `.__clk_get_name' > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): > undefined reference to `.clk_hw_register' > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): > undefined reference to `.of_clk_add_provider' > > Add the missing COMMON_CLK dependency to fix this errors. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Thanks for your patch! But did this change really fix your PowerPC allyesconfig build? SND_SOC_ALL_CODECS will still select it... Fix sent. Disclaimer: tested with m68k/allmodconfig only ;-) Gr{oetje,eeting}s, Geert
Hi Geert, On Tue, 4 Feb 2020 14:21:01 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > > Looks like some platforms are not yet using COMMON CLK. > > > > PowerPC allyesconfig failed with below error in next > > > > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): > > undefined reference to `of_clk_src_simple_get' > > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe': > > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): > > undefined reference to `.__clk_get_name' > > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): > > undefined reference to `.clk_hw_register' > > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): > > undefined reference to `.of_clk_add_provider' > > > > Add the missing COMMON_CLK dependency to fix this errors. > > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Thanks for your patch! > > But did this change really fix your PowerPC allyesconfig build? It does not :-( > SND_SOC_ALL_CODECS will still select it... > > Fix sent. I have applied that patch to linux-next today.
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c9eb683bd1b0..286514865960 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1334,6 +1334,7 @@ config SND_SOC_WCD9335 config SND_SOC_WCD934X tristate "WCD9340/WCD9341 Codec" + depends on COMMON_CLK depends on MFD_WCD934X help The WCD9340/9341 is a audio codec IC Integrated in
Looks like some platforms are not yet using COMMON CLK. PowerPC allyesconfig failed with below error in next ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): undefined reference to `of_clk_src_simple_get' ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe': wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): undefined reference to `.__clk_get_name' ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): undefined reference to `.clk_hw_register' ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): undefined reference to `.of_clk_add_provider' Add the missing COMMON_CLK dependency to fix this errors. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- Changes since v1: - Rebased on top of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git next branch sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+)