| Message ID | 20200311010908.42366-9-jbi.octave@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Wed, 11 Mar 2020 02:09:08 +0100, Jules Irenge wrote: > > Sparse reports a warning at tscm_hwdep_read_locked() > > warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock > > The root cause is the missing annotation at tscm_hwdep_read_locked() > Add the missing __releases(&tscm->lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied, thanks. Takashi
diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c index 9801e33e7f2a..6f38335fe10b 100644 --- a/sound/firewire/tascam/tascam-hwdep.c +++ b/sound/firewire/tascam/tascam-hwdep.c @@ -17,6 +17,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf, long count, loff_t *offset) + __releases(&tscm->lock) { struct snd_firewire_event_lock_status event = { .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,
Sparse reports a warning at tscm_hwdep_read_locked() warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock The root cause is the missing annotation at tscm_hwdep_read_locked() Add the missing __releases(&tscm->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- sound/firewire/tascam/tascam-hwdep.c | 1 + 1 file changed, 1 insertion(+)