| Message ID | 20200409185827.16255-4-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d233c4941630af0ec2e14be7c2a693e9c9ce3087 |
| Headers | show |
| Series | ASoC: Intel: machine drivers update for 5.8 | expand |
On Thu, 09 Apr 2020 20:58:17 +0200, Pierre-Louis Bossart wrote: > > From: Libin Yang <libin.yang@linux.intel.com> > > Add HDMI codec vid for the Intel ElkhartLake platform > > Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> > Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> > Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> > Signed-off-by: Libin Yang <libin.yang@linux.intel.com> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> I suppose this can go through ASoC tree unless HDA legacy driver supports the device. Acked-by: Takashi Iwai <tiwai@suse.de> thanks, Takashi
Hey, On Sat, 11 Apr 2020, Takashi Iwai wrote: > On Thu, 09 Apr 2020 20:58:17 +0200, Pierre-Louis Bossart wrote: >> Add HDMI codec vid for the Intel ElkhartLake platform > > I suppose this can go through ASoC tree unless HDA legacy driver > supports the device. hmm, good point. In short, both DSP and non-DSP usage continue to be possible, so HDA legacy driver can be used as well. This is a (positive) new problem of SOF now using common codec driver for HDMI. The patch got merged already (and I think this is ok as we specifically enable and test HDMI with the ASoC stack), but maybe in the future we can send these codec driver patches directly, and not via ASoC. Br, Kai
On Tue, 14 Apr 2020 18:09:58 +0200, Kai Vehmanen wrote: > > Hey, > > On Sat, 11 Apr 2020, Takashi Iwai wrote: > > > On Thu, 09 Apr 2020 20:58:17 +0200, Pierre-Louis Bossart wrote: > >> Add HDMI codec vid for the Intel ElkhartLake platform > > > > I suppose this can go through ASoC tree unless HDA legacy driver > > supports the device. > > hmm, good point. In short, both DSP and non-DSP usage continue to be > possible, so HDA legacy driver can be used as well. This is a (positive) > new problem of SOF now using common codec driver for HDMI. The patch got > merged already (and I think this is ok as we specifically enable and test > HDMI with the ASoC stack), but maybe in the future we can send these codec > driver patches directly, and not via ASoC. I thought ELK controller code wasn't present in HDA legacy side, but it's been already there. So yeah, this could have been merged through my tree better, but it's no big problem for now as the platform is too new and not found in market yet :) If any, we can sync in the early RC, if Mark can send a pull request. I always prefer it in general. thanks, Takashi
>> On Thu, 09 Apr 2020 20:58:17 +0200, Pierre-Louis Bossart wrote: >>> Add HDMI codec vid for the Intel ElkhartLake platform >> >> I suppose this can go through ASoC tree unless HDA legacy driver >> supports the device. > > hmm, good point. In short, both DSP and non-DSP usage continue to be > possible, so HDA legacy driver can be used as well. This is a (positive) > new problem of SOF now using common codec driver for HDMI. The patch got > merged already (and I think this is ok as we specifically enable and test > HDMI with the ASoC stack), but maybe in the future we can send these codec > driver patches directly, and not via ASoC. ElkhartLake support was added to the legacy driver a while back (5.3). Don't ask me why the hdmi codec id was not added at the time, it was indeed a miss. I chose to send this patch as part of the ASoC series, so that at least we have consistency. Takashi, if you prefer it that way feel free to take this patch in your tree, but then Mark would need a tag for the rest of this series. I agree with Kai that moving forward the hdmi codec parts should be better tracked. Thanks -Pierre
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 5119a9ae3d8a..e473247f1a14 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -4289,6 +4289,7 @@ HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI", patch_i915_icl_hdmi), HDA_CODEC_ENTRY(0x80862812, "Tigerlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x8086281a, "Jasperlake HDMI", patch_i915_icl_hdmi), +HDA_CODEC_ENTRY(0x8086281b, "Elkhartlake HDMI", patch_i915_icl_hdmi), HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi), HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI", patch_i915_byt_hdmi), HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI", patch_i915_byt_hdmi),