diff mbox series

[v2,1/2] dt-bindings: sound: add Microsemi ZL38060 binding

Message ID 20200417221341.31428-1-TheSven73@gmail.com (mailing list archive)
State Accepted
Commit 19f303caf63693502cf34897ade76202afe5f445
Headers show
Series [v2,1/2] dt-bindings: sound: add Microsemi ZL38060 binding | expand

Commit Message

Sven Van Asbroeck April 17, 2020, 10:13 p.m. UTC
Add devicetree binding for the Microsemi ZL38060 Connected
Home Audio Processor.

Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---

Tree: v5.7-rc1

v1->v2:

- removed all properties related to amp-en-gpios
- removed 'mscc,load-firmware' property

For further details, see v1->v2 notes in 2nd patch.

 .../devicetree/bindings/sound/zl38060.yaml    | 69 +++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/zl38060.yaml

Comments

Mark Brown April 20, 2020, 12:15 p.m. UTC | #1
On Fri, Apr 17, 2020 at 06:13:40PM -0400, Sven Van Asbroeck wrote:

> +maintainers:
> +  - Jaroslav Kysela <perex@perex.cz>
> +  - Takashi Iwai <tiwai@suse.com>

This is supposed to be people maintianing this specific binding, not the
subsystem.
Sven Van Asbroeck April 20, 2020, 12:22 p.m. UTC | #2
On Mon, Apr 20, 2020 at 8:15 AM Mark Brown <broonie@kernel.org> wrote:
>
> > +maintainers:
> > +  - Jaroslav Kysela <perex@perex.cz>
> > +  - Takashi Iwai <tiwai@suse.com>
>
> This is supposed to be people maintianing this specific binding, not the
> subsystem.

That would be Liam and yourself?
Mark Brown April 20, 2020, 12:25 p.m. UTC | #3
On Mon, Apr 20, 2020 at 08:22:57AM -0400, Sven Van Asbroeck wrote:
> On Mon, Apr 20, 2020 at 8:15 AM Mark Brown <broonie@kernel.org> wrote:

> > > +maintainers:
> > > +  - Jaroslav Kysela <perex@perex.cz>
> > > +  - Takashi Iwai <tiwai@suse.com>

> > This is supposed to be people maintianing this specific binding, not the
> > subsystem.

> That would be Liam and yourself?

I'd expect someone with knowledge of the hardware such as yourself.
Sven Van Asbroeck April 20, 2020, 12:50 p.m. UTC | #4
On Mon, Apr 20, 2020 at 8:25 AM Mark Brown <broonie@kernel.org> wrote:
>
> I'd expect someone with knowledge of the hardware such as yourself.

I claim no expertise - I was just getting tired of dragging the
out-of-tree vendor
driver for this chip from kernel to kernel. AFAIK, most people using this chip
have forked the vendor driver and adapted it to their specific needs.

If my name has to be there, I'd be keen to hand it over once someone more
familiar with this chip comes along.

Hopefully someone from Microsemi will be monitoring this discussion.
Mark Brown April 20, 2020, 12:53 p.m. UTC | #5
On Mon, Apr 20, 2020 at 08:50:45AM -0400, Sven Van Asbroeck wrote:
> On Mon, Apr 20, 2020 at 8:25 AM Mark Brown <broonie@kernel.org> wrote:
> >
> > I'd expect someone with knowledge of the hardware such as yourself.
> 
> I claim no expertise - I was just getting tired of dragging the
> out-of-tree vendor
> driver for this chip from kernel to kernel. AFAIK, most people using this chip
> have forked the vendor driver and adapted it to their specific needs.

> If my name has to be there, I'd be keen to hand it over once someone more
> familiar with this chip comes along.

I think by virtue of taking this step you have become the de facto
upstream expert on this chip!  Like you say hopefully someone more
familiar (ideally from Microsemi) will turn up.
Mark Brown April 21, 2020, 6:22 p.m. UTC | #6
On Fri, 17 Apr 2020 18:13:40 -0400, Sven Van Asbroeck wrote:
> Add devicetree binding for the Microsemi ZL38060 Connected
> Home Audio Processor.
> 
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
> 
> Tree: v5.7-rc1
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8

Thanks!

[1/2] dt-bindings: sound: add Microsemi ZL38060 binding
      commit: 19f303caf63693502cf34897ade76202afe5f445
[2/2] ASoC: Add initial ZL38060 driver
      commit: 52e8a94baf9026276fcdc9ff21a50dc2ca0bc94b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/zl38060.yaml b/Documentation/devicetree/bindings/sound/zl38060.yaml
new file mode 100644
index 000000000000..338e2a13c775
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/zl38060.yaml
@@ -0,0 +1,69 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/zl38060.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ZL38060 Connected Home Audio Processor from Microsemi.
+
+description: |
+  The ZL38060 is a "Connected Home Audio Processor" from Microsemi,
+  which consists of a Digital Signal Processor (DSP), several Digital
+  Audio Interfaces (DAIs), analog outputs, and a block of 14 GPIOs.
+
+maintainers:
+  - Jaroslav Kysela <perex@perex.cz>
+  - Takashi Iwai <tiwai@suse.com>
+
+properties:
+  compatible:
+    const: mscc,zl38060
+
+  reg:
+    description:
+      SPI device address.
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 24000000
+
+  reset-gpios:
+    description:
+      A GPIO line handling reset of the chip. As the line is active low,
+      it should be marked GPIO_ACTIVE_LOW (see ../gpio/gpio.txt)
+    maxItems: 1
+
+  '#gpio-cells':
+    const: 2
+
+  gpio-controller: true
+
+  '#sound-dai-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - '#gpio-cells'
+  - gpio-controller
+  - '#sound-dai-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    spi0 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec: zl38060@0 {
+            gpio-controller;
+            #gpio-cells = <2>;
+            #sound-dai-cells = <0>;
+            compatible = "mscc,zl38060";
+            reg = <0>;
+            spi-max-frequency = <12000000>;
+            reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
+        };
+    };