| Message ID | 20200428214754.3925368-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | be16a0f0dc8fab8e25d9cdbeb4f8f28afc9186d2 |
| Headers | show |
| Series | ASoC: component: suppress uninitialized-variable warning | expand |
On Tue, 28 Apr 2020 23:47:31 +0200, Arnd Bergmann wrote: > Old versions of gcc (tested on gcc-4.8) produce a warning for > correct code: > > sound/soc/soc-compress.c: In function 'soc_compr_open': > sound/soc/soc-compress.c:75:28: error: 'component' is used uninitialized in this function [-Werror=uninitialized] > struct snd_soc_component *component, *save = NULL; > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/1] ASoC: component: suppress uninitialized-variable warning commit: be16a0f0dc8fab8e25d9cdbeb4f8f28afc9186d2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/include/sound/soc.h b/include/sound/soc.h index 907afbc652f2..69a82487fa9b 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -1179,7 +1179,7 @@ struct snd_soc_pcm_runtime { #define asoc_rtd_to_codec(rtd, n) (rtd)->dais[n + (rtd)->num_cpus] #define for_each_rtd_components(rtd, i, component) \ - for ((i) = 0; \ + for ((i) = 0, component = NULL; \ ((i) < rtd->num_components) && ((component) = rtd->components[i]);\ (i)++) #define for_each_rtd_cpu_dais(rtd, i, dai) \
Old versions of gcc (tested on gcc-4.8) produce a warning for correct code: sound/soc/soc-compress.c: In function 'soc_compr_open': sound/soc/soc-compress.c:75:28: error: 'component' is used uninitialized in this function [-Werror=uninitialized] struct snd_soc_component *component, *save = NULL; Change the for_each_rtd_components() macro to ensure 'component' gets initialized to a value the compiler does not complain about. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- include/sound/soc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)