| Message ID | 20200501133534.6706-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8c149b7d75e53be47648742f40fc90d9fc6fa63a |
| Headers | show |
| Series | dt-bindings: sound: wm8994: Correct required supplies based on actual implementaion | expand |
On Fri, May 01, 2020 at 03:35:34PM +0200, Krzysztof Kozlowski wrote: > The required supplies in bindings were actually not matching > implementation making the bindings incorrect and misleading. The Linux > kernel driver requires all supplies to be present. Also for wlf,wm8994 > uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>). > > Reported-by: Jonathan Bakker <xc-racer2@live.ca> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Fri, 1 May 2020 15:35:34 +0200, Krzysztof Kozlowski wrote: > The required supplies in bindings were actually not matching > implementation making the bindings incorrect and misleading. The Linux > kernel driver requires all supplies to be present. Also for wlf,wm8994 > uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>). > > Reported-by: Jonathan Bakker <xc-racer2@live.ca> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/1] dt-bindings: sound: wm8994: Correct required supplies based on actual implementaion commit: 8c149b7d75e53be47648742f40fc90d9fc6fa63a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/wm8994.txt b/Documentation/devicetree/bindings/sound/wm8994.txt index 68cccc4653ba..367b58ce1bb9 100644 --- a/Documentation/devicetree/bindings/sound/wm8994.txt +++ b/Documentation/devicetree/bindings/sound/wm8994.txt @@ -14,9 +14,15 @@ Required properties: - #gpio-cells : Must be 2. The first cell is the pin number and the second cell is used to specify optional parameters (currently unused). - - AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply, - SPKVDD1-supply, SPKVDD2-supply : power supplies for the device, as covered - in Documentation/devicetree/bindings/regulator/regulator.txt + - power supplies for the device, as covered in + Documentation/devicetree/bindings/regulator/regulator.txt, depending + on compatible: + - for wlf,wm1811 and wlf,wm8958: + AVDD1-supply, AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, + DCVDD-supply, CPVDD-supply, SPKVDD1-supply, SPKVDD2-supply + - for wlf,wm8994: + AVDD1-supply, AVDD2-supply, DBVDD-supply, DCVDD-supply, CPVDD-supply, + SPKVDD1-supply, SPKVDD2-supply Optional properties: @@ -73,11 +79,11 @@ wm8994: codec@1a { lineout1-se; + AVDD1-supply = <®ulator>; AVDD2-supply = <®ulator>; CPVDD-supply = <®ulator>; - DBVDD1-supply = <®ulator>; - DBVDD2-supply = <®ulator>; - DBVDD3-supply = <®ulator>; + DBVDD-supply = <®ulator>; + DCVDD-supply = <®ulator>; SPKVDD1-supply = <®ulator>; SPKVDD2-supply = <®ulator>; };
The required supplies in bindings were actually not matching implementation making the bindings incorrect and misleading. The Linux kernel driver requires all supplies to be present. Also for wlf,wm8994 uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>). Reported-by: Jonathan Bakker <xc-racer2@live.ca> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../devicetree/bindings/sound/wm8994.txt | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)