diff mbox series

[1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225"

Message ID 20200503152449.22761-1-kai.heng.feng@canonical.com (mailing list archive)
State New, archived
Headers show
Series [1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" | expand

Commit Message

Kai-Heng Feng May 3, 2020, 3:24 p.m. UTC 
This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757.

Enable power save node breaks some systems with ACL225. Revert the patch
and use a platform specific quirk for the original issue isntead.

Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225")
BugLink: https://bugs.launchpad.net/bugs/1875916
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Takashi Iwai May 3, 2020, 7:02 p.m. UTC | #1 
On Sun, 03 May 2020 17:24:46 +0200,
Kai-Heng Feng wrote:
> 
> This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757.
> 
> Enable power save node breaks some systems with ACL225. Revert the patch
> and use a platform specific quirk for the original issue isntead.
> 
> Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225")
> BugLink: https://bugs.launchpad.net/bugs/1875916
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied now.  Thanks.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b26f0acfd86e..dedf0c17f198 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8246,8 +8246,6 @@  static int patch_alc269(struct hda_codec *codec)
 		spec->gen.mixer_nid = 0;
 		break;
 	case 0x10ec0225:
-		codec->power_save_node = 1;
-		/* fall through */
 	case 0x10ec0295:
 	case 0x10ec0299:
 		spec->codec_variant = ALC269_TYPE_ALC225;